Refactor signal handling and replace signal handlers with thread-safe functions by pcanal · Pull Request #1053 · root-project/root

pcanal · 2017-09-25T21:55:25Z

This is an update of #134 to work compile on MacOS and rename TSigHandling into TSignalManager.

This is a work in progress as the new TSignalManager no longer calls TSystem::StackTrace but is also only implementing support for unix systems.

@zzxuanyuan Could you update the code to support at least MacOS (and attempt to support Windows)?

…edicated to handling signals of the system

…ngException

…) and CheckChilds() from TUnixSystem.cxx

gRootDir should only be set in TUnixSystem. Switch call order to insure it is set when needed

phsft-bot · 2017-09-25T21:55:39Z

Starting build on centos7/gcc49, mac1012/native, slc6/gcc49, slc6/gcc62, ubuntu14/native with flags -Dvc=OFF -Dimt=ON -Dccache=ON
How to customize builds

phsft-bot · 2017-09-25T22:42:14Z

Build failed on ubuntu14/native.
See console output.

Failing tests:

zzxuanyuan · 2017-09-26T19:24:18Z

I will look at it. @pcanal @bbockelm what is the common way to develop software in MacOS? Should I build ROOT on my laptop? or use some virtual machine with MacOS installed?

amadio · 2017-10-03T12:27:49Z

@zzxuanyuan You can build on MacOS if you have a full version of XCode installed (command line tools only are not enough). If you have CVMFS, you can get some of the externals from there too. Just let me know and I'll show you how to do it.

bbockelm · 2017-10-18T13:20:18Z

@zzxuanyuan - any updates on getting this to work on OS X?

etejedor · 2018-02-20T13:20:04Z

@zzxuanyuan any updates on this PR?

amadio

I think this pull request needs to be changed to avoid ifdefs, as there are too many, and to not add something and change it later, but just add the final version directly. Otherwise, it should be squashed upon merging, as the history here is not useful (e.g. adding file with Author: Fons Rademakers 15/09/95 to then change Author... in a later commit, adding Exit(), changing to gSystem->Exit() then removing the added code in later commit, etc).

amadio · 2019-01-28T10:25:50Z

 #pragma link C++ class TSubString;
 #pragma link C++ class TSysEvtHandler;
-#pragma link C++ class TSigHandling+;
+#pragma link C++ class TSignalManager+;


Please amend the original commit instead of adding it with one name and then renaming.

amadio · 2019-01-28T10:33:10Z

+               fcntl(fd, F_SETFL, flags);
+            }
+            return -ETIMEDOUT;
+         } else { }


Why have an empty else clause?

amadio · 2019-01-28T10:34:20Z

+      if (complete == -1) {
+         if (errno == EINTR) { continue; }
+         else if ((errno == EAGAIN) || (errno == EWOULDBLOCK)) { continue; }
+         else {


This is not following coding conventions. Please format new code appropriately before committing.

amadio · 2019-01-28T10:39:27Z

+      SignalSafeErrWrite("Unable to pre-allocate executable information");
+      return;
+   }   
+#endif


Please remove this #ifdef and use TROOT::GetEtcDir() or equivalent.

amadio · 2019-01-28T10:46:36Z

+   syscall(SYS_execve, "/bin/sh", argv, __environ);
+#else
+   execv("/bin/sh", argv);
+#endif


Why not use the same for Linux and non-Linux? What's the advantage of this and other similar #ifdefs?
For instance, why not use evecve() from unistd.h? It's a POSIX interface.

amadio · 2019-01-28T10:51:15Z

+         SignalSafeErrWrite("(Failed to wait on stack dump output.)\n");
+         Exit(1, kFALSE);
+      } else {
+         Exit(0, kFALSE);


Please just add the final version instead of adding Exit() then changing to gSystem->Exit() in a later commit.

amadio · 2019-01-28T10:56:23Z

+   if (-1 == pipe(gStackTraceHelper.fChildToParent))
+#else
+   if (-1 == pipe2(gStackTraceHelper.fChildToParent, O_CLOEXEC))
+#endif


Please just use pipe() and remove the #ifdef. This is unnecessary complexity.
https://www.usenix.org/legacy/publications/library/proceedings/sa92/spencer.pdf

amadio · 2019-01-28T10:59:12Z

 ROOT_GLOB_SOURCES(sources ${CMAKE_CURRENT_SOURCE_DIR}/src/*.cxx)

-set(Unix_dict_headers  ${CMAKE_CURRENT_SOURCE_DIR}/inc/T*.h PARENT_SCOPE)
+ROOT_GLOB_HEADERS(headers ${CMAKE_CURRENT_SOURCE_DIR}/inc/T*.h)


ROOT_GLOB_HEADERS() is not allowed anymore. Please list all files. This is a pre-requisite to solve ROOT-5998.

lmoneta · 2019-01-29T15:45:38Z

@pcanal is this PR still relevant ?

zzxuanyuan · 2019-01-29T16:10:07Z

@pcanal Is there any update on signal handler on MacOS? Do I still need to work on this one?

hageboeck · 2020-09-14T14:56:28Z

Converted to draft in order to be able to remove the do not merge label.

phsft-bot · 2020-09-14T14:56:36Z

Starting build on ROOT-debian10-i386/cxx14, ROOT-performance-centos7-multicore/default, ROOT-fedora30/cxx14, ROOT-fedora31/noimt, ROOT-ubuntu16/nortcxxmod, mac1014/python3, mac1015/cxx17, windows10/cxx14
How to customize builds

phsft-bot · 2020-09-14T14:58:40Z

Build failed on mac1014/python3.
Running on macphsft17.dyndns.cern.ch:/build/jenkins/workspace/root-pullrequests-build
See cdash.
See console output.

Errors:

[2020-09-14T14:58:39.882Z] CMake Error at /build/jenkins/workspace/root-pullrequests-build/rootspi/jenkins/root-build.cmake:982 (message):

phsft-bot · 2020-09-14T15:01:09Z

Build failed on ROOT-ubuntu16/nortcxxmod.
Running on sft-ubuntu-1604-4.cern.ch:/build/workspace/root-pullrequests-build
See cdash.
See console output.

Errors:

[2020-09-14T15:01:06.764Z] CMake Error at /mnt/build/workspace/root-pullrequests-build/rootspi/jenkins/root-build.cmake:982 (message):

phsft-bot · 2020-09-14T15:05:27Z

Build failed on ROOT-fedora31/noimt.
Running on root-fedora-31-2.cern.ch:/home/sftnight/build/workspace/root-pullrequests-build
See cdash.
See console output.

Errors:

[2020-09-14T15:05:27.021Z] CMake Error at /home/sftnight/build/workspace/root-pullrequests-build/rootspi/jenkins/root-build.cmake:982 (message):

phsft-bot · 2020-09-14T15:14:06Z

Build failed on ROOT-fedora30/cxx14.
Running on root-fedora30-2.cern.ch:/home/sftnight/build/workspace/root-pullrequests-build
See cdash.
See console output.

Errors:

[2020-09-14T15:14:05.523Z] CMake Error at /home/sftnight/build/workspace/root-pullrequests-build/rootspi/jenkins/root-build.cmake:982 (message):

phsft-bot · 2020-09-14T15:36:50Z

Build failed on ROOT-performance-centos7-multicore/default.
Running on olhswep22.cern.ch:/data/sftnight/workspace/root-pullrequests-build
See cdash.
See console output.

Errors:

[2020-09-14T15:36:49.690Z] CMake Error at /data/sftnight/workspace/root-pullrequests-build/rootspi/jenkins/root-build.cmake:982 (message):

phsft-bot · 2020-09-14T15:37:02Z

Build failed on ROOT-debian10-i386/cxx14.
Running on pcepsft10.dyndns.cern.ch:/build/workspace/root-pullrequests-build
See cdash.
See console output.

Errors:

[2020-09-14T15:37:01.438Z] CMake Error at /home/sftnight/build/workspace/root-pullrequests-build/rootspi/jenkins/root-build.cmake:982 (message):

phsft-bot · 2020-09-14T15:53:10Z

Build failed on mac1015/cxx17.
Running on macphsft18.dyndns.cern.ch:/Users/sftnight/build/jenkins/workspace/root-pullrequests-build
See cdash.
See console output.

Errors:

[2020-09-14T15:53:09.394Z] CMake Error at /Users/sftnight/build/jenkins/workspace/root-pullrequests-build/rootspi/jenkins/root-build.cmake:982 (message):

phsft-bot · 2020-09-14T15:54:30Z

Build failed on windows10/cxx14.
Running on null:C:\build\workspace\root-pullrequests-build
See cdash.
See console output.

Errors:

[2020-09-14T15:54:30.086Z] CMake Error at C:/build/workspace/root-pullrequests-build/rootspi/jenkins/root-build.cmake:982 (message):

zzxuanyuan and others added 14 commits September 25, 2017 16:46

Created a new class TSigHandling out of TSystem and TSigHandling is d…

fabd0dc

…edicated to handling signals of the system

Change functions in signal handlers to be thread-safe

4607986

Change auxiliary functions in TUnixSigHandling to gSystem functions

1ebb53f

Changed Author and removed type cast and includes handling kSigFloati…

ea4472d

…ngException

Type casting gSystem to TUnixSystem and directly call DispatchTimers(…

c637b65

…) and CheckChilds() from TUnixSystem.cxx

Update signal handling setup calls for MacOSX

c112524

Avoid code duplication.

275d3db

gRootDir should only be set in TUnixSystem. Switch call order to insure it is set when needed

Use proper glob supporting setter

4ae76d1

Remove redundant code guard. Sort include.

fa50533

Remove #ifdef __CINT__

93b4643

White space

b6bbe3a

TFdSet deduplication (now just in TUnixSystem.h)

81b94c9

Remove unnecessary include, forward decl

6c238e3

Rename TSigHandling* to TSignalManager*

90767fe

pcanal added the do not merge label Sep 25, 2017

pcanal requested a review from Axel-Naumann September 25, 2017 21:55

pcanal requested a review from peremato as a code owner September 25, 2017 21:55

pcanal mentioned this pull request Sep 25, 2017

Refactor signal handling and replace signal handlers with thread-safe functions #134

Closed

amadio assigned pcanal and amadio Oct 3, 2017

amadio removed their assignment Oct 5, 2017

amadio requested changes Jan 28, 2019

View reviewed changes

pcanal mentioned this pull request Dec 6, 2019

[Exp PyROOT] New exception handler - cppyy patch #4671

Merged

eguiraud added the stale label Mar 10, 2020

hageboeck marked this pull request as draft September 14, 2020 14:55

Axel-Naumann removed the stale label Sep 14, 2020

hageboeck removed the do not merge label Sep 14, 2020

pcanal mentioned this pull request May 10, 2022

[GH] Allow starting Bug Report from ROOT prompt with prepopulated setup field #10366

Merged

12 tasks

ferdymercury added the in:Core Libraries label Apr 15, 2024

ferdymercury requested review from silverweed and removed request for Axel-Naumann and peremato August 29, 2025 13:26

Conversation

pcanal commented Sep 25, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

phsft-bot commented Sep 25, 2017

Uh oh!

phsft-bot commented Sep 25, 2017

Failing tests:

Uh oh!

zzxuanyuan commented Sep 26, 2017

Uh oh!

amadio commented Oct 3, 2017

Uh oh!

bbockelm commented Oct 18, 2017

Uh oh!

etejedor commented Feb 20, 2018

Uh oh!

amadio left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

lmoneta commented Jan 29, 2019

Uh oh!

zzxuanyuan commented Jan 29, 2019

Uh oh!

hageboeck commented Sep 14, 2020

Uh oh!

phsft-bot commented Sep 14, 2020

Uh oh!

phsft-bot commented Sep 14, 2020

Errors:

Uh oh!

phsft-bot commented Sep 14, 2020

Errors:

Uh oh!

phsft-bot commented Sep 14, 2020

Errors:

Uh oh!

phsft-bot commented Sep 14, 2020

Errors:

Uh oh!

phsft-bot commented Sep 14, 2020

Errors:

Uh oh!

phsft-bot commented Sep 14, 2020

Errors:

Uh oh!

phsft-bot commented Sep 14, 2020

Errors:

Uh oh!

phsft-bot commented Sep 14, 2020

Errors:

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

11 participants

pcanal commented Sep 25, 2017 •

edited

Loading