Skip to content

[windows] work-around a compiler bug with VS 2022 v17.6.0 #13071

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
hahnjo merged 1 commit into from
Jun 24, 2023
Merged

[windows] work-around a compiler bug with VS 2022 v17.6.0 #13071

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion interpreter/llvm/llvm-project.tag
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1 @@
ROOT-llvm13-20230517-02
ROOT-llvm13-20230623-01
7 changes: 7 additions & 0 deletions interpreter/llvm/src/lib/Target/X86/MCTargetDesc/X86MCCodeEmitter.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -703,6 +703,13 @@ bool X86MCCodeEmitter::emitPrefixImpl(unsigned &CurOp, const MCInst &MI,
HasREX = emitOpcodePrefix(MemoryOperand, MI, STI, OS);

uint64_t Form = TSFlags & X86II::FormMask;
// FIXME (bellenot): Visual Studio v17.6.0 makes root.exe crash
// at the switch statement with Form being 0x002 or 0x001, values
// normally going to the 'default' switch branch, so the behavior
// doesn't change.
// To be reviewed and removed as soon as VS works again
if (Form <= 0x002)
return HasREX;
switch (Form) {
default:
break;
Expand Down