Fix bug in DiagProd calculation#13111
Merged
Merged
Conversation
|
Can one of the admins verify this patch? |
Contributor
|
@phsft-bot build |
|
Starting build on |
Contributor
Fixes a small bug in calculation of product of diagonal terms in LU matrix decompositions. A unit test to cover the former bug is also implemented.
guitargeek
force-pushed
the
fix-diagprod
branch
from
December 14, 2023 13:24
1c6cb58 to
63613f1
Compare
Contributor
|
@phsft-bot build |
|
Starting build on |
guitargeek
approved these changes
Dec 14, 2023
guitargeek
left a comment
guitargeek
left a comment
Contributor
There was a problem hiding this comment.
Thank you very much for fixing this and providing a unit test!
This was referenced Dec 16, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This Pull request:
Changes or fixes:
Small bug in calculation of product of diagonal terms in LU matrix decompositions
This PR fixes #13110