Skip to content

[cmake] Remove usage of --src-root with llvm-config#13366

Merged
hahnjo merged 1 commit into
root-project:masterfrom
stephanlachnit:p-remove-src-root
Aug 2, 2023
Merged

[cmake] Remove usage of --src-root with llvm-config#13366
hahnjo merged 1 commit into
root-project:masterfrom
stephanlachnit:p-remove-src-root

Conversation

@stephanlachnit

Copy link
Copy Markdown
Contributor

This Pull request:

Changes or fixes:

Remove usage of --src-root, which is removed in LLVM16 (#13273). See also hahnjo#1. Only relevant for external LLVM and works without this anyway.

Checklist:

  • tested changes locally
  • updated the docs (if necessary)

@phsft-bot

Copy link
Copy Markdown

Starting build on ROOT-debian10-i386/soversion, ROOT-performance-centos8-multicore/cxx17, ROOT-ubuntu2204/nortcxxmod, ROOT-ubuntu2004/python3, mac11/noimt, mac12arm/cxx20, windows10/default
How to customize builds

@hahnjo

hahnjo commented Aug 1, 2023

Copy link
Copy Markdown
Member

To elaborate based on the motivation to remove --src-root from llvm-config (llvm/llvm-project@c061892): The returned path might sometimes work if LLVM was built and installed on the same machine. The likelier setup is wanting to use distributed binaries of LLVM, in which case --src-root doesn't exist anyway.

@vgvassilev vgvassilev left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense to me.

@github-actions

github-actions Bot commented Aug 2, 2023

Copy link
Copy Markdown

Test Results

         9 files           9 suites   2d 5h 38m 32s ⏱️
  2 476 tests   2 474 ✔️ 0 💤 2
21 183 runs  21 181 ✔️ 0 💤 2

For more details on these failures, see this check.

Results for commit 23a56fb.

@hahnjo hahnjo merged commit e8930ae into root-project:master Aug 2, 2023
@hahnjo hahnjo mentioned this pull request Aug 2, 2023
23 tasks
@stephanlachnit stephanlachnit deleted the p-remove-src-root branch August 2, 2023 08:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants