Skip to content

[RF] Support PDFs produced by RooClassFactory in codegen + AD#13812

Merged
guitargeek merged 3 commits into
root-project:masterfrom
guitargeek:rooclassfactory_ad
Oct 10, 2023
Merged

[RF] Support PDFs produced by RooClassFactory in codegen + AD#13812
guitargeek merged 3 commits into
root-project:masterfrom
guitargeek:rooclassfactory_ad

Conversation

@guitargeek

@guitargeek guitargeek commented Oct 6, 2023 •
edited
Loading

Copy link
Copy Markdown
Contributor

This also includes rudimentary support for numeric integrals in 1D with
the codegen backend as a demonstrator.

A second commit cleans up the RooFuncWrapper class a little bit.

A unit test that fits a 1D function created with the RooClassFactory using codegen is also added.

@guitargeek guitargeek self-assigned this Oct 6, 2023
@phsft-bot

phsft-bot commented Oct 6, 2023

Copy link
Copy Markdown

Starting build on ROOT-performance-centos8-multicore/soversion, ROOT-ubuntu2204/nortcxxmod, ROOT-ubuntu2004/python3, mac11/noimt, mac12arm/cxx20, windows10/default
How to customize builds

@phsft-bot

phsft-bot commented Oct 6, 2023

Copy link
Copy Markdown

Starting build on ROOT-performance-centos8-multicore/soversion, ROOT-ubuntu2204/nortcxxmod, ROOT-ubuntu2004/python3, mac11/noimt, mac12arm/cxx20, windows10/default
How to customize builds

@phsft-bot

phsft-bot commented Oct 6, 2023

Copy link
Copy Markdown

Starting build on ROOT-performance-centos8-multicore/soversion, ROOT-ubuntu2204/nortcxxmod, ROOT-ubuntu2004/python3, mac11/noimt, mac12arm/cxx20, windows10/default
How to customize builds

@phsft-bot

phsft-bot commented Oct 6, 2023

Copy link
Copy Markdown

Build failed on mac12arm/cxx20.
Running on macphsft26.dyndns.cern.ch:/Users/sftnight/build/workspace/root-pullrequests-build
See console output.

Failing tests:

@guitargeek
[RF] Support PDFs produced by RooClassFactory in codegen + AD
f74240b 
This also includes rudimentary support for numeric integrals in 1D with
the codegen backend as a demonstrator.
@guitargeek
[RF] Clean up RooFuncWrapper
0a2132f 
* Avoid duplicate names for functions declared to the interpreter

* Remove now unused constructor that directly takes the C++ code
  (this was only used in early development)
@guitargeek
[RF] Code-format RooClassFactory.cxx
75a917e 
The file got changed a lot recently, so it's a good opportunity to
format it.
@phsft-bot

phsft-bot commented Oct 6, 2023

Copy link
Copy Markdown

Starting build on ROOT-performance-centos8-multicore/soversion, ROOT-ubuntu2204/nortcxxmod, ROOT-ubuntu2004/python3, mac11/noimt, mac12arm/cxx20, windows10/default
How to customize builds

@github-actions

github-actions Bot commented Oct 6, 2023

Copy link
Copy Markdown

Test Results

       11 files         11 suites   2d 9h 33m 22s ⏱️
  2 483 tests   2 482 ✔️ 0 💤 1 ❌
26 228 runs  26 226 ✔️ 0 💤 2 ❌

For more details on these failures, see this check.

Results for commit 75a917e.

lmoneta
lmoneta approved these changes Oct 10, 2023
View reviewed changes

@lmoneta lmoneta left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!
Thank you Jonas for this nice new feature!

@guitargeek guitargeek mentioned this pull request Oct 10, 2023
Closed
23 tasks
@guitargeek
guitargeek merged commit e6e1380 into root-project:master Oct 10, 2023
@guitargeek
guitargeek deleted the rooclassfactory_ad branch October 10, 2023 14:14
@guitargeek guitargeek mentioned this pull request Oct 18, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lmoneta lmoneta lmoneta approved these changes
@hageboeck hageboeck Awaiting requested review from hageboeck hageboeck is a code owner

Assignees

@guitargeek guitargeek

Labels

in:RooFit

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@guitargeek @phsft-bot @lmoneta