[RF] Also support Offset("bin") in simul. fits with legacy backend#13890
Merged
Conversation
|
Starting build on |
23 tasks
It should return `Value::Cuda` of course.
Also support the `Offset("bin")` feature in simultaneous fits with the
legacy evaluation backend (e.g., the old test statistic classes).
In this case, The top-level `RooNLLVar` actually doesn't do anything
but contains pointers to the NLLs for the individual channels. The
function call to enable the offsetting must be delegated to those.
A unit test that covers this is also implemented.
Note that for the new CPU evaluation backend, this is working already.
guitargeek
force-pushed
the
offset_bin_fixup
branch
from
October 20, 2023 08:40
b076f04 to
6c054f0
Compare
|
Starting build on |
This is important for full HistFactory model support.
|
Starting build on |
This is a very useful developer tool, because one can see what the coverage of RooFit is if the legacy evaluation backend is not present, without having to worry that is is still used in some code path.
It was not meaningful to have a clone on the `stressRooFit` tests suite just for a single test that compares pdf values, and it didn't even use the reference file mechanism from `RooUnitTest`. Since future unit tests are not added to the `stress` suites anymore but added as gtests, we might as well also migrate the single test that was formerly `stressHistFactory`.
|
Starting build on |
|
Build failed on windows10/default. Errors:
And 12 more |
|
Build failed on mac12arm/cxx20. Errors:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Also support the
Offset("bin")feature in simultaneous fits with thelegacy evaluation backend (e.g., the old test statistic classes).
In this case, The top-level
RooNLLVaractually doesn't do anythingbut contains pointers to the NLLs for the individual channels. The
function call to enable the offsetting must be delegated to those.
A unit test that covers this is also implemented.
Note that for the new CPU evaluation backend, this is working already.
A second commit in this PR is fixing a copy-paste error in the functions that define the evaluation backend.