[minuit2] Fix Minuit 2 standalone build#14026
Merged
Merged
Conversation
guitargeek
requested review from
Axel-Naumann,
bellenot and
lmoneta
as code owners
November 7, 2023 13:45
|
Starting build on |
23 tasks
I recently introduced a `R__HAS_MINUIT2` macro when moving to Minuit 2 as the default. Introducing this macro broke the standalone build of `mathcore`, because `RConfig.h` was now required. This commit is avoiding that by using cmake definitions instead. Follows up on 6866a57.
Follows up on 8ce465c. That commit introduced two months ago a copying of the `ROOTConfig-version.cmake` file to the Minuit 2 standalone build dir. However, this file is only available after building ROOT, as it's generated from the `ROOTConfig-version.cmake.in` template. A ROOT build should not be required for Minuit 2 standalone. Therefore, this commit suggests a different way to get the ROOT version number: by inspecting the header files from the ROOT source.
guitargeek
force-pushed
the
minuit2_standalone
branch
from
November 13, 2023 09:43
f068219 to
7ee7466
Compare
|
Starting build on |
lmoneta
approved these changes
Nov 13, 2023
lmoneta
left a comment
lmoneta
left a comment
Member
There was a problem hiding this comment.
LGTM!
Thank you Jonas for fixing this!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up on two recent PRs that independently broke the standalone Minuit 2 built:
More detail in the commit description.
Addresses the following forum post:
https://root-forum.cern.ch/t/standalone-minuit2/57006