[CMake] Always build Minuit2#14100
Merged
Merged
Conversation
|
Starting build on |
lmoneta
approved these changes
Nov 23, 2023
lmoneta
left a comment
lmoneta
left a comment
Member
There was a problem hiding this comment.
I agree with this change, it simplifies also the build system and the testing!
In the discussion thread to JIRA ticket ROOT-10864, Axel suggested the
removal of the option to disable minuit2 as a possible solution.
I think this is a very good idea good idea, because:
* Minuit2 only depends on `Hist` and `MathCore` anyway.
* Now that Minuit2 is the default for *all* minimization in ROOT,
building ROOT without Minuit2 changes the behavior of ROOT way too
much, in a ways that people that set `minuit2=OFF` probably are not
intending or aware of.
This closes the following JIRA ticket:
https://sft.its.cern.ch/jira/browse/ROOT-10864
guitargeek
force-pushed
the
minuit2_always
branch
from
November 23, 2023 17:02
54309b0 to
75f7923
Compare
|
Starting build on |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In the discussion thread to JIRA ticket ROOT-10864, Axel suggested the removal of the option to disable minuit2 as a possible solution.
I think this is a very good idea good idea, because:
Minuit2 only depends on
HistandMathCoreanyway.Now that Minuit2 is the default for all minimization in ROOT, building ROOT without Minuit2 changes the behavior of ROOT way too much, in a ways that people that set
minuit2=OFFprobably are not intending or aware of.This closes the following JIRA ticket:
https://sft.its.cern.ch/jira/browse/ROOT-10864