Skip to content

[RF][HF] Do not access non-existent parameter when setting it to const in HistoToWorkspaceFactoryFast #14249

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
guitargeek merged 1 commit into from
Dec 16, 2023
Merged

[RF][HF] Do not access non-existent parameter when setting it to const in HistoToWorkspaceFactoryFast #14249

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions roofit/histfactory/src/HistoToWorkspaceFactoryFast.cxx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1253,11 +1253,12 @@ RooArgList HistoToWorkspaceFactoryFast::createObservables(const TH1 *hist, RooWo
for(unsigned int i=0; i<systToFix.size(); ++i){
RooRealVar* temp = proto.var(systToFix.at(i));
if(!temp) {
cxcoutE(HistFactory) << "could not find variable " << systToFix.at(i)
cxcoutW(HistFactory) << "could not find variable " << systToFix.at(i)
<< " could not set it to constant" << endl;
} else {
// set the parameter constant
temp->setConstant();
}
// set the parameter constant
temp->setConstant();
}

//////////////////////////////////////
Expand Down