ROOT-5076: Support random access compression#152
Closed
zzxuanyuan wants to merge 17 commits into
Closed
Conversation
…et called randomaccesscompression
When the TBasket gets de-streamed, it goes to TBufferFile::ReadObjectAny() This function calls CheckByteCount and it complains the fBufCur does not match endpos The reason might be due to the streamer when we write data to TBasket. Because the difference between fBurCur and endpos is exactly 804 bytes which is the size- -of array (Compressed?)EntryOffset. Further examination needed. By the way, TNamed::Class() and TObject::Class() returns a TClass. For debug purpose, we could print (TClass *)clss->GetName() which is the class name.
…amer Class info to the file. In TBasket::Streamer(), it should not include the compression entry offsets if TBasket is going to stream the fBufferRef as well in which case flag = 11.
…n uncompressed size 1. Added combine test file which writes hybird of TInt, TLarge, TSmall into a single file 2. We need to compare nout(compressed objects)+compoffkey(compressed entry offsets) with fObjlen
| /// the expected behavior when there is no cache. | ||
|
|
||
| Int_t TBasket::ReadBasketBuffers(Long64_t pos, Int_t len, TFile *file) | ||
| Int_t TBasket::ReadBasketBuffers(Long64_t pos, Int_t len, TFile *file, Bool_t random, Long64_t relativeentry) |
Member
There was a problem hiding this comment.
random is too generic a name, please consider using a different spelling. thanks.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a new feature to support random access compression. For details, please take a look at this link:
https://sft.its.cern.ch/jira/browse/ROOT-5076