Skip to content

[win][ASAN] Fix ASAN build on Windows #16586

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bellenot merged 2 commits into from
Oct 3, 2024
Merged

[win][ASAN] Fix ASAN build on Windows #16586

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
228a4f8
[win][ASAN] Fix ASAN build on Windows
bellenot Oct 3, 2024
1372d9b
[scope] clang-format
bellenot Oct 3, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions core/base/src/TObject.cxx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -117,6 +117,12 @@ bool DeleteChangesMemoryImpl()
// can guess this is always the case and we can rely on the changes to fBits made
// by ~TObject to detect use-after-delete error (and print a message rather than
// stop the program with a segmentation fault)
#if defined(_MSC_VER) && defined(__SANITIZE_ADDRESS__)
// on Windows, even __declspec(no_sanitize_address) does not prevent catching
// heap-use-after-free errorswhen using the /fsanitize=address compiler flag
// so don't even try
return true;
#endif
if ( *o_fbits != 0x01000000 ) {
// operator delete tainted the memory, we can not rely on TestBit(kNotDeleted)
return true;
Expand Down