Draft: RDataSpec fix for input files on EOS#17537
Closed
TomasDado wants to merge 1 commit into
Closed
Conversation
pcanal
reviewed
Jan 27, 2025
| // remote files e.g. on EOS. The path stored in "id" does contain the prefix. | ||
| // Thus, a check is performed if the id substring is found in the keys of the map | ||
| auto itrSample = std::find_if(fSampleMap.begin(), fSampleMap.end(), | ||
| [&id](const auto& element) {return id.find(element.first) != std::string::npos;}); |
Member
There was a problem hiding this comment.
This is likely to relax and might confused similar name, for example "first_file.root" and "file.root".
Contributor
Author
There was a problem hiding this comment.
thanks @pcanal. Indeed, this was just an initial idea so that I can discuss with the develoports what is the best way to tackle the issue
pcanal
requested changes
Jan 27, 2025
pcanal
left a comment
pcanal
left a comment
Member
There was a problem hiding this comment.
See comment. We should also try to add some tests.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This Pull request:
Changes or fixes:
Changing the code that checks the internal cache of the RDF files based on their paths to only check the substring to allow for cases where the input file is on a remote disk e.g. via EOS
Checklist:
This PR fixes #17449