Skip to content

cling: Add ROOT lock to LookupHelper::findType #18237

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dpiparo merged 1 commit into from
Apr 3, 2025
Merged

cling: Add ROOT lock to LookupHelper::findType #18237

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions interpreter/cling/lib/Interpreter/LookupHelper.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,8 @@
#include "clang/Sema/Template.h"
#include "clang/Sema/TemplateDeduction.h"

#include "EnterUserCodeRAII.h"

using namespace clang;

namespace cling {
Expand Down Expand Up @@ -472,6 +474,13 @@ namespace cling {

if (typeName.empty()) return TheQT;

// findType is called from TClingLookupHelper::GetPartiallyDesugaredNameWithScopeHandling
// which is called indirectly from TClassEdit::GetNormalizedName via
// the ResolvedTypedef code paths. Through that code path nothing is
// taking the ROOT/Interpreter lock and since this code can modify the
// interpreter, we do need to take lock.
LockCompilationDuringUserCodeExecutionRAII LCDUCER(*m_Interpreter);

// Could trigger deserialization of decls.
Interpreter::PushTransactionRAII RAII(m_Interpreter);

Expand Down