[v634] Fix macOS15.4 builds#18243
Merged
dpiparo merged 5 commits intoApr 5, 2025
Merged
Conversation
Test Results 18 files 18 suites 4d 5h 40m 36s ⏱️ For more details on these failures, see this check. Results for commit f64a844. ♻️ This comment has been updated with latest results. |
devajithvs
changed the title
devajithvs
force-pushed
the
v6-34-00-patches
branch
2 times, most recently
from
64c1c65 to
f64d463
Compare
devajithvs
force-pushed
the
v6-34-00-patches
branch
from
f64d463 to
1254801
Compare
`less` is defined in functional according to the C++ standard. (cherry picked from commit 82858ce)
…roject#18231) * [runtime-cxxmodules] Adapt the darwin modulemaps to sdk 15.4. * [runtime-cxmodules] Use separate modulemap for macOS15.2 * [runtime-cxxmodules] Add overlay entry for MacOSX15.2 --------- Co-authored-by: Devajith Valaparambil Sreeramaswamy <devajith.valaparambil.sreeramaswamy@cern.ch> (cherry picked from commit ff43ae8)
Clang may emit calls to compiler-rt symbols such as __divdc3 for std::complex<T> division. These may not be resolved during JIT'ing on macOS when using Cling. This patch forward-declares the relevant symbols and explicitly injects them into the JIT symbol table. Similar to: root-project@4b6075b (cherry picked from commit 038ee1f)
to address the new behaviour of the compiler shipped with XCode 16.3
devajithvs
force-pushed
the
v6-34-00-patches
branch
from
cffa8e1 to
40fb476
Compare
4 tasks
devajithvs
force-pushed
the
v6-34-00-patches
branch
2 times, most recently
from
2f6b26f to
f64a844
Compare
Contributor
Author
|
Marking it ready for review. I can't figure out why the CI fails for mac beta. I am not able to reproduce the CI error by logging into the same machine and building with the same configuration. Does anyone have an idea why this might be happening? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This Pull request:
Backports of:
Fixing macOS15.4 builds
Changes or fixes:
Checklist:
This PR fixes #