Skip to content

[fortran] fix bug when copying/memmoving string #19236

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
ferdymercury wants to merge 4 commits into from
Closed

[fortran] fix bug when copying/memmoving string #19236

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
fa1c7f7
[fortran] fix bug when copying/memmoving string
ferdymercury Jun 30, 2025
4661a7e
[h2root] revert workaround in C
ferdymercury Jun 30, 2025
c090c7a
[ci] enable fortran on macos
ferdymercury Jun 30, 2025
6622027
[ci] disable on mac14 since it's still failing
ferdymercury Jul 1, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/root-ci-config/buildconfig/mac13.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
CMAKE_BUILD_RPATH=/usr/local/lib
asimage_tiff=OFF
builtin_cfitsio=ON
builtin_cppzmq=ON
Expand Down Expand Up @@ -27,7 +28,6 @@ builtin_zeromq=ON
builtin_zstd=ON
ccache=ON
cocoa=ON
fortran=OFF
minuit2_omp=OFF
pythia8=OFF
test_distrdf_dask=ON
Expand Down
6 changes: 1 addition & 5 deletions main/src/h2root.cxx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -312,11 +312,7 @@ int main(int argc, char **argv)

int lun = 10;
#ifndef WIN32
// "px" is a string being changed to "pxc" in the fortran side; since it's a temporary on C's side,
// we need a buffer of at least 3 chars on Cs side, too. Predefine it as a extra variable "px " since that way
// the space will be replaced by 'c' on the preallocated memory, instead of appending a new char (new memory) to "px".
auto opt = PASSCHAR("px ");
hropen(lun,PASSCHAR("example"),PASSCHAR(file_in),opt,record_size,ier,7,strlen(file_in),2);
hropen(lun,PASSCHAR("example"),PASSCHAR(file_in),PASSCHAR("px"),record_size,ier,7,strlen(file_in),2);
#else
hropen(lun,PASSCHAR("example"),PASSCHAR(file_in),PASSCHAR("px"),record_size,ier);
#endif
Expand Down
3 changes: 3 additions & 0 deletions misc/minicern/src/hbook.f
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -249,6 +249,9 @@ SUBROUTINE HROPEN(LUN,CHDIR,CFNAME,CHOPTT,LRECL,ISTAT)
CHARACTER*(*) CFNAME,CHDIR,CHOPTT
CHARACTER*8 CHOPT
CHOPT=CHOPTT
DO 11 I=LEN(CHOPTT)+1,8
CHOPT(I:I) = ' '
11 CONTINUE
CALL CLTOU(CHOPT)
DO 10 I=1,NCHTOP
IF(CFNAME.EQ.HFNAME(I))THEN
Expand Down
Loading