[main] rootbrowse: instance a TRint instead of TApplication#20681
Merged
Conversation
ferdymercury
approved these changes
Dec 10, 2025
Collaborator
ferdymercury
left a comment
ferdymercury
left a comment
There was a problem hiding this comment.
Thanks a lot!
On Line 133: shouldn't it be "TRint" rather than "TApplication" ? Or since it is parent class, it doesn't matter?
Contributor
Author
It being a virtual function it's probably equivalent, but I'm not sure so I'll change it to TRint, thanks! |
silverweed
force-pushed
the
rootbrowse_trint
branch
from
f5c6509 to
5f17c05
Compare
guitargeek
approved these changes
Dec 10, 2025
Test Results 20 files 20 suites 3d 11h 31m 5s ⏱️ Results for commit f913676. ♻️ This comment has been updated with latest results. |
This gives 2 advantages: it executes .rootlogon.C on startup (like the old rootbrowse did) and it provides an interactive prompt to the user while using rootbrowse.
silverweed
force-pushed
the
rootbrowse_trint
branch
from
5f17c05 to
f913676
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This gives 2 advantages: it executes .rootlogon.C on startup (like the old rootbrowse did) and it provides an interactive prompt to the user while using rootbrowse.
Checklist:
This PR fixes #20674