Skip to content

[RF] Don't use removeServer to clean RooAbsAnaConvPdf compute graph #21065

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
guitargeek merged 1 commit into from
Jan 30, 2026
Merged

[RF] Don't use removeServer to clean RooAbsAnaConvPdf compute graph #21065

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 0 additions & 5 deletions roofit/roofitcore/src/RooAbsAnaConvPdf.cxx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -697,11 +697,6 @@ RooAbsAnaConvPdf::compileForNormSet(RooArgSet const &normSet, RooFit::Detail::Co
}
std::unique_ptr<RooAbsAnaConvPdf> pdfClone(static_cast<RooAbsAnaConvPdf *>(this->Clone()));

// The actual resolution model is not serving the RooAbsAnaConvPdf
// in the evaluation. It was only used get the convolutions with a given
// basis. We can remove it for the compiled model.
pdfClone->removeServer(const_cast<RooAbsReal &>(pdfClone->_model.arg()), true);

// The other servers will be compiled with the original normSet, but the
// _convSet has to be evaluated unnormalized.
RooArgList convArgClones;
Expand Down
Loading