[cling][test] Improve comments in recursion value printer test#21113
Merged
Conversation
Test Results0 tests 0 ✅ 0s ⏱️ Results for commit 9491610. |
pcanal
approved these changes
Feb 3, 2026
Member
pcanal
left a comment
pcanal
left a comment
There was a problem hiding this comment.
LGTM.
SIde note: the original fix is only handling a some sub-space of the category of self-referential and circular containers (i.e. any container that is directly or indirectly circular will still crash, the original PR only handle the case where it is strictly directly self-referential).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This Pull request:
Clarify the comment as per suggestion by Philippe: #21072 (comment)
Changes or fixes:
Checklist:
This PR fixes #