Skip to content

[gpad] do not overwrite the title of the last PDF page when closing#21245

Merged
couet merged 1 commit into
root-project:masterfrom
ferdymercury:patch-20
Feb 12, 2026
Merged

[gpad] do not overwrite the title of the last PDF page when closing#21245
couet merged 1 commit into
root-project:masterfrom
ferdymercury:patch-20

Conversation

@ferdymercury
Copy link
Copy Markdown
Collaborator

@ferdymercury ferdymercury commented Feb 11, 2026

This Pull request:

Changes or fixes:

[gpad] do not overwrite the title of the last PDF page when closing unless explicitly passing the Title flag in the close command.

Fixes #21244

Checklist:

  • tested changes locally
  • updated the docs (if necessary)

@ferdymercury
[gpad] do not overwrite the title of the last PDF page when closing
7d6f538 
unless explicitly passing the Title flag in the close command.

Fixes root-project#21244
@ferdymercury ferdymercury marked this pull request as ready for review February 11, 2026 11:04
@ferdymercury ferdymercury requested a review from couet as a code owner February 11, 2026 11:04
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Feb 11, 2026

Test Results

    22 files      22 suites   3d 7h 47m 37s ⏱️
 3 791 tests  3 790 ✅ 0 💤 1 ❌
76 270 runs  76 269 ✅ 0 💤 1 ❌

For more details on these failures, see this check.

Results for commit 7d6f538.

@ferdymercury ferdymercury mentioned this pull request Feb 12, 2026
Closed
1 task
couet
couet approved these changes Feb 12, 2026
View reviewed changes
Copy link
Copy Markdown
Member

@couet couet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@couet couet merged commit b825d6a into root-project:master Feb 12, 2026
28 of 30 checks passed
@dpiparo
Copy link
Copy Markdown
Member

dpiparo commented Feb 12, 2026

/backport to 6.38

root-project-bot pushed a commit to root-project-bot/root that referenced this pull request Feb 12, 2026
@ferdymercury
[gpad] do not overwrite the title of the last PDF page when closing (r…
ecfb2bb 
…oot-project#21245)

unless explicitly passing the Title flag in the close command.

Fixes root-project#21244

(cherry picked from commit b825d6a)
@root-project-bot root-project-bot mentioned this pull request Feb 12, 2026
Merged
@root-project-bot
Copy link
Copy Markdown

root-project-bot commented Feb 12, 2026

This PR has been backported to branch 6.38: #21259

couet pushed a commit that referenced this pull request Feb 12, 2026
@root-project-bot @ferdymercury
[gpad] do not overwrite the title of the last PDF page when closing (#…
f163ded 
…21245) (#21259)

unless explicitly passing the Title flag in the close command.

Fixes #21244

(cherry picked from commit b825d6a)

Co-authored-by: ferdymercury <ferdymercury@users.noreply.github.com>
@ferdymercury ferdymercury deleted the patch-20 branch February 12, 2026 12:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@couet couet couet approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

TPad Print() Title option issue

4 participants

@ferdymercury @dpiparo @root-project-bot @couet