Skip to content

[CI] When tests fail on Windows, rerun them with --rerun-failed -j1 #22785

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
hageboeck merged 2 commits into from
Jul 14, 2026
Merged

[CI] When tests fail on Windows, rerun them with --rerun-failed -j1 #22785

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
33626e7
[CI] Try using ctest --rerun-failed on Windows.
hageboeck Jul 10, 2026
d9b7dcf
[NFC] Make ruff happier with build_root.py
hageboeck Jul 10, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 9 additions & 3 deletions .github/workflows/root-ci-config/build_root.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,9 +57,9 @@ def main():
if pull_request:
# We check whether the PR is done from a branch that has the same name of
# the target branch in the ROOT repository using base_ref and head_ref:
# - The base_ref is e.g. "master" or "v6-38-00-patches"
# - The base_ref is e.g. "master" or "v6-38-00-patches"
# - The head_ref for PRs is formatted as <PR branch>:<Fork branch> e.g. "refs/pull/20742/head:cppyy_fixup"
if not ":" in args.head_ref:
if ":" not in args.head_ref:
build_utils.print_error(f"This has been identified as a PR build. However, the head-ref is {args.head_ref}.")
branch_in_fork = args.head_ref.split(":")[-1]
if branch_in_fork == args.base_ref:
Expand All @@ -85,7 +85,7 @@ def main():

if "minimal" in platform_options and platform_options["minimal"] == "ON":
options_dict = platform_options
print(f"Minimal build detected in the platform options. Ignoring global configuration.")
print("Minimal build detected in the platform options. Ignoring global configuration.")
else:
options_dict.update(platform_options)
print(f"Build option overrides for {args.platform_config}:")
Expand Down Expand Up @@ -372,6 +372,12 @@ def run_ctest(extra_ctest_flags: str) -> int:
{setupROOTEnv}
ctest --output-on-failure --parallel {os.cpu_count()} --output-junit TestResults.xml {extra_ctest_flags}
""")
if WINDOWS and ctest_result != 0:
ctest_result = subprocess_with_log(f"""
cd '{builddir}'
{setupROOTEnv}
ctest --output-on-failure --rerun-failed --output-junit TestResults.xml {extra_ctest_flags}
""")

return ctest_result

Expand Down
Loading