[6.40] [tree] In TBasket/TBranch, error out if reading oob in the streamer#22815
Open
silverweed wants to merge 4 commits into
Open
[6.40] [tree] In TBasket/TBranch, error out if reading oob in the streamer#22815silverweed wants to merge 4 commits into
silverweed wants to merge 4 commits into
Conversation
(cherry picked from commit fe1be25)
(cherry picked from commit 143c1d0)
(cherry picked from commit aa344c0)
Following 15d2d71, fEntryOffset is (conditionally) allocated with a capacity of fNevBuf, i.e. the number of elements that are read into it. However, one code path in WriteBuffer() writes fEntryOffset up to one past the fNevBuf-th element, causing an OOB write. This was (usually) not happening prior to the aforementioned commit because fEntryOffset was allocated with a default capacity of 1000 (even though all elements past the fNevBuf-th were never initialized). To fix the OOB write, we now allocate one extra element when reading fEntryOffset from disk so that the WriteBuffer write is not OOB anymore. (cherry picked from commit 45efd3c)
Test Results 22 files 22 suites 3d 10h 5m 25s ⏱️ Results for commit a1cda71. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of #22165