Only download test data if running the test that needs them#402
Merged
Conversation
|
Can one of the admins verify this patch? |
Closed
Contributor
|
Hi Mattias. I do not think this works. The DEPENDS in ROOT_ADD_TEST() is intended for adding dependencies between tests. The solution is probably adding a 'pre-command' to the test |
Contributor
|
@phsft-bot build |
gganis
pushed a commit
to gganis/root
that referenced
this pull request
Apr 3, 2017
…ject#402) * Only download test data if running the test that needs them * Copy test data in the pre-command of the test
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The TestData target is currently declared ALL, which means it is always executed during the build.
However, the data it downloads is only used for running the stressProof test, so if this test is not run the downloaded data files are not needed.
By removing the TestData target from ALL and making it a requirement of the test-stressproof target instead, the files are only downloaded if they are needed. Disabling the stressProof test now also disables the download of the data files. This is important when building in an environment without network access.