[PyROOT] Add test for implicit import from the ROOT namespace#5361
Merged
Conversation
Contributor
Author
|
@etejedor Why we haven't seen this before? I'm wondering 🤔 |
Contributor
Author
|
This is blocked by the issue here: https://sft.its.cern.ch/jira/browse/ROOT-10688 |
Contributor
Author
|
@etejedor We still want/need these tests? |
Contributor
|
@stwunsch yes, we don't have any equivalent, do we? |
stwunsch
force-pushed
the
pyroot-rootns
branch
from
August 31, 2020 09:31
b91d538 to
6cc5b15
Compare
This was referenced Mar 25, 2021
stwunsch
marked this pull request as draft
April 9, 2021 10:13
guitargeek
marked this pull request as ready for review
October 18, 2023 13:44
guitargeek
force-pushed
the
pyroot-rootns
branch
from
October 18, 2023 13:54
6cc5b15 to
6e23abd
Compare
|
Starting build on |
guitargeek
approved these changes
Oct 18, 2023
guitargeek
left a comment
guitargeek
left a comment
Contributor
There was a problem hiding this comment.
Never harms to add a test it the CI will be green now
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I see some import failures from
ROOT.RVecin #5310, added a test here.