Skip to content

[io] Protect out-of-bounds access in R__WriteDestructorBody:#5642

Merged
Axel-Naumann merged 1 commit into
root-project:masterfrom
Axel-Naumann:TStreamerInfoWriteDtorBody-MemError
May 18, 2020
Merged

[io] Protect out-of-bounds access in R__WriteDestructorBody:#5642
Axel-Naumann merged 1 commit into
root-project:masterfrom
Axel-Naumann:TStreamerInfoWriteDtorBody-MemError

Conversation

@Axel-Naumann
Copy link
Copy Markdown
Member

@Axel-Naumann Axel-Naumann commented May 18, 2020 •
edited
Loading

Fixes assert in roottest/root/meta/MakeProject/runcms310.C

/builddir/build/BUILD/gcc-8.3.1-20190223/obj-x86_64-redhat-linux/x86_64-redhat-linux/libstdc++-v3/include/bits/basic_string.h:1067: std::__cxx11::basic_string<_CharT, _Traits, _Alloc>::reference std::__cxx11::basic_string<_CharT, _Traits, _Alloc>::operator[](std::__cxx11::basic_string<_CharT, _Traits, _Alloc>::size_type) [with _CharT = char; _Traits = std::char_traits<char>; _Alloc = std::allocator<char>; std::__cxx11::basic_string<_CharT, _Traits, _Alloc>::reference = char&; std::__cxx11::basic_string<_CharT, _Traits, _Alloc>::size_type = long unsigned int]: Assertion '__pos <= size()' failed.
#3  0x00007ffff78c7c11 in std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> >::operator[](unsigned long) () from /lib64/libstdc++.so.6
#4  0x00007ffff67fb9c3 in R__WriteDestructorBody (file=0x1e01c10, next=...)
    at /mnt/build/wsincrmaster/LABEL/ROOT-fedora29/SPEC/python3/root/io/io/src/TStreamerInfo.cxx:3531
#5  0x00007ffff67fcfcf in TStreamerInfo::GenerateDeclaration (this=0x2b1e950, fp=0x1d7ddc0, sfp=0x1e01c10,
    subClasses=0x7fffffff8db0, top=true)
    at /mnt/build/wsincrmaster/LABEL/ROOT-fedora29/SPEC/python3/root/io/io/src/TStreamerInfo.cxx:3772
#6  0x00007ffff67fe2bf in TStreamerInfo::GenerateHeaderFile (this=0x2b1e950, dirname=0x7fffffff92d9 "cms310",
    subClasses=0x7fffffff8db0, extrainfos=0x7fffffff9210)
    at /mnt/build/wsincrmaster/LABEL/ROOT-fedora29/SPEC/python3/root/io/io/src/TStreamerInfo.cxx:3976
#7  0x00007ffff67a99bf in TFile::MakeProject (this=0x158e280, dirname=0x7ffff793204c "cms310", option=0x7ffff7932055 "RECREATE+")
    at /mnt/build/wsincrmaster/LABEL/ROOT-fedora29/SPEC/python3/root/io/io/src/TFile.cxx:2843

@Axel-Naumann Axel-Naumann requested a review from pcanal as a code owner May 18, 2020 10:25
@Axel-Naumann Axel-Naumann self-assigned this May 18, 2020
@Axel-Naumann
[io] Protect out-of-bounds access in R__WriteDestructorBody:
3cc128d 
Fixes assert in roottest/root/meta/MakeProject/runcms310.C
```
/builddir/build/BUILD/gcc-8.3.1-20190223/obj-x86_64-redhat-linux/x86_64-redhat-linux/libstdc++-v3/include/bits/basic_string.h:1067: std::__cxx11::basic_string<_CharT, _Traits, _Alloc>::reference std::__cxx11::basic_string<_CharT, _Traits, _Alloc>::operator[](std::__cxx11::basic_string<_CharT, _Traits, _Alloc>::size_type) [with _CharT = char; _Traits = std::char_traits<char>; _Alloc = std::allocator<char>; std::__cxx11::basic_string<_CharT, _Traits, _Alloc>::reference = char&; std::__cxx11::basic_string<_CharT, _Traits, _Alloc>::size_type = long unsigned int]: Assertion '__pos <= size()' failed.
    at /mnt/build/wsincrmaster/LABEL/ROOT-fedora29/SPEC/python3/root/io/io/src/TStreamerInfo.cxx:3531
    subClasses=0x7fffffff8db0, top=true)
    at /mnt/build/wsincrmaster/LABEL/ROOT-fedora29/SPEC/python3/root/io/io/src/TStreamerInfo.cxx:3772
    subClasses=0x7fffffff8db0, extrainfos=0x7fffffff9210)
    at /mnt/build/wsincrmaster/LABEL/ROOT-fedora29/SPEC/python3/root/io/io/src/TStreamerInfo.cxx:3976
    at /mnt/build/wsincrmaster/LABEL/ROOT-fedora29/SPEC/python3/root/io/io/src/TFile.cxx:2843
```

where

```
(gdb) p inside
$1 = std::vector of length 3, capacity 4 = {"std::vector", "std::pair<edm::BranchKey,edm::BranchDescription>", ""}
```
@phsft-bot
Copy link
Copy Markdown

phsft-bot commented May 18, 2020

Starting build on ROOT-debian10-i386/cxx14, ROOT-performance-centos7-multicore/default, ROOT-fedora29/python3, ROOT-fedora30/cxx14, ROOT-fedora31/noimt, ROOT-ubuntu16/nortcxxmod, mac1015/cxx17, windows10/cxx14
How to customize builds

@Axel-Naumann Axel-Naumann force-pushed the TStreamerInfoWriteDtorBody-MemError branch from 0167a18 to 3cc128d Compare May 18, 2020 10:27
@phsft-bot
Copy link
Copy Markdown

phsft-bot commented May 18, 2020

Starting build on ROOT-debian10-i386/cxx14, ROOT-performance-centos7-multicore/default, ROOT-fedora29/python3, ROOT-fedora30/cxx14, ROOT-fedora31/noimt, ROOT-ubuntu16/nortcxxmod, mac1015/cxx17, windows10/cxx14
How to customize builds

@phsft-bot
Copy link
Copy Markdown

phsft-bot commented May 18, 2020

Build failed on ROOT-fedora31/noimt.
Running on root-fedora-31-1.cern.ch:/build/workspace/root-pullrequests-build
See cdash.
See console output.

Failing tests:

@phsft-bot
Copy link
Copy Markdown

phsft-bot commented May 18, 2020

Build failed on ROOT-fedora30/cxx14.
Running on root-fedora30-2.cern.ch:/home/sftnight/build/workspace/root-pullrequests-build
See cdash.
See console output.

Failing tests:

@phsft-bot
Copy link
Copy Markdown

phsft-bot commented May 18, 2020

Build failed on ROOT-fedora29/python3.
Running on root-fedora29-2.cern.ch:/build/workspace/root-pullrequests-build
See cdash.
See console output.

Failing tests:

@phsft-bot
Copy link
Copy Markdown

phsft-bot commented May 18, 2020

Build failed on ROOT-ubuntu16/nortcxxmod.
Running on sft-ubuntu-1604-4.cern.ch:/build/workspace/root-pullrequests-build
See cdash.
See console output.

Failing tests:

1 similar comment
@phsft-bot
Copy link
Copy Markdown

phsft-bot commented May 18, 2020

Build failed on ROOT-ubuntu16/nortcxxmod.
Running on sft-ubuntu-1604-4.cern.ch:/build/workspace/root-pullrequests-build
See cdash.
See console output.

Failing tests:

@phsft-bot
Copy link
Copy Markdown

phsft-bot commented May 18, 2020

Build failed on mac1015/cxx17.
Running on macphsft20.dyndns.cern.ch:/Users/sftnight/build/workspace/root-pullrequests-build
See cdash.
See console output.

Failing tests:

@phsft-bot
Copy link
Copy Markdown

phsft-bot commented May 18, 2020

Build failed on ROOT-debian10-i386/cxx14.
Running on pcepsft10.dyndns.cern.ch:/build/workspace/root-pullrequests-build
See cdash.
See console output.

Failing tests:

@Axel-Naumann Axel-Naumann merged commit 97c62d4 into root-project:master May 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pcanal pcanal pcanal approved these changes

Assignees

@Axel-Naumann Axel-Naumann

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Axel-Naumann @phsft-bot @pcanal