Skip to content

[cmake] Ask for PROCESSOR_DESCRIPTION if cmake version is 3.10 or later. #6605

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
oshadura merged 1 commit into from
Oct 12, 2020
Merged

[cmake] Ask for PROCESSOR_DESCRIPTION if cmake version is 3.10 or later. #6605

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -649,7 +649,12 @@ if(testing)
endif()
endif()

cmake_host_system_information(RESULT PROCESSOR QUERY PROCESSOR_DESCRIPTION)
if (${CMAKE_VERSION} VERSION_GREATER_EQUAL "3.10.0")
if (${CMAKE_MINIMUM_REQUIRED_VERSION} VERSION_GREATER_EQUAL "3.10.0")
message(FATAL_ERROR "Remove this condition")

@davidrohr davidrohr May 17, 2021

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This breaks the compilation for me, when a dependency is pulled in, which sets a higher minimum required cmake version. Why is this check and the fatal error needed? Wouldn't it be sufficient to just check if (${CMAKE_VERSION} VERSION_GREATER_EQUAL "3.10.0")

endif()
cmake_host_system_information(RESULT PROCESSOR QUERY PROCESSOR_DESCRIPTION)
endif()

message(STATUS "ROOT Configuration \n
System ${CMAKE_SYSTEM}
Expand Down