[cmake] Build only the library of the xrootd client#7539
Merged
Conversation
|
Starting build on |
|
Build failed on ROOT-fedora31/noimt. Errors:
|
|
Build failed on ROOT-ubuntu16/nortcxxmod. Errors:
|
Contributor
Author
|
Uhm, this flag seems to disable more than expected :/ |
Collaborator
|
It will be possible probably only with #7335 |
Contributor
Author
|
Thanks for pointing this out! |
|
Build failed on ROOT-performance-centos8-multicore/default. Errors:
|
|
Build failed on ROOT-fedora30/cxx14. Errors:
|
|
Build failed on mac11.0/cxx17. Errors:
|
|
Build failed on mac1014/python3. Errors:
|
|
Build failed on ROOT-debian10-i386/cxx14. Errors:
|
|
Build failed on windows10/cxx14. Failing tests: |
Contributor
Author
|
I've just investigated and indeed with xrootd5 it should work like this, though in the current inbuilt version it's basically impossible to make this work with existing cmake flags. So waiting for #7335 :) |
stwunsch
marked this pull request as draft
April 9, 2021 10:15
- Enabled by the XRDCL_LIB_ONLY=ON cmake flag - Prevents building the client binaries such as xrdcp in our build dir but not exposing them in the installation Fixes root-project#7441
guitargeek
marked this pull request as ready for review
October 18, 2023 09:47
guitargeek
force-pushed
the
xrd-client-lib-only
branch
from
October 18, 2023 09:47
7d7a36e to
f16f683
Compare
|
Starting build on |
guitargeek
approved these changes
Oct 18, 2023
guitargeek
left a comment
guitargeek
left a comment
Contributor
There was a problem hiding this comment.
Thanks! It's a good idea to not build the binary artifacts if they are not used 👍
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hey! One commit I found locally, may be used to fix #7441
but not exposing them in the installation
Fixes #7441