Skip to content

RooFit MultiProcess and TestStatistics #8294

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
egpbos wants to merge 518 commits into from
Closed

RooFit MultiProcess and TestStatistics #8294

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
518 commits
Select commit Hold shift + click to select a range
edc17b1
WIP: InterProcessQueueAndMessenger
egpbos Mar 7, 2018
f58f294
BidirMMapPipe: add move constructor
egpbos Mar 7, 2018
5f7cb74
WIP: MultiProcess_Vector compiles!
egpbos Mar 7, 2018
43ee2fd
WIP: MultiProcess_Vector: try with BidirMMapPipe pointers
egpbos Mar 8, 2018
b2604e2
Revert f58f294: BidirMMapPipe: add move constructor
egpbos Mar 8, 2018
e4e0668
WIP: switching queue and director process roles
egpbos Mar 8, 2018
bb37d86
WIP: MP::Vector runs without hanging, but still not correctly
egpbos Mar 8, 2018
f7f0845
WIP: added debug prints for MP::Vector
egpbos Mar 8, 2018
53be50e
WIP: more debug prints for MP::Vector and fixed message integers
egpbos Mar 8, 2018
4bf9460
WIP: missing a break in a case! Now still hanging at the end...
egpbos Mar 8, 2018
8888d05
Parallel test passing
egpbos Mar 12, 2018
5887f44
Workers close without assert fail... but getting random SIGPIPE kills
egpbos Mar 12, 2018
1c781a5
Seems like random SIGPIPE kills are fixed using other terminate protocol
egpbos Mar 12, 2018
ce99818
Clean up commented out code
egpbos Mar 12, 2018
97af39e
More clean-up
egpbos Mar 12, 2018
2718900
More clean-up + added test for multiple jobs
egpbos Mar 12, 2018
7dfc0fc
Disabled test for multiple jobs (segfaults, but low-priority atm)
egpbos Mar 12, 2018
24c4678
Rename tests + add RooNLLVar parallelization test
egpbos Mar 12, 2018
ed043f4
WIP: RooNLLVar parallellization test built (still broken)
egpbos Mar 14, 2018
4bcf8bb
num_tasks_from_cpus removed (not used)
egpbos Mar 15, 2018
c3238cc
changes in BidirMMapPipe to allow children to inherit
ipelupessy Mar 16, 2018
8ac4ecf
fix for shutdown of remotely passed BidirMMapPipe
ipelupessy Mar 19, 2018
e3572c7
Merge branch 'MultiProcess_Vector' of https://github.com/roofit-dev/r…
egpbos Mar 21, 2018
9fe8149
WIP: converting MP::Vector back to director==master structure
egpbos Mar 22, 2018
191b11b
Added remove_job_object to IPQM
egpbos Mar 22, 2018
2b2a039
Add tests for multiple worker processes
egpbos Mar 22, 2018
9b17382
Fix tests for multiple worker processes
egpbos Mar 22, 2018
f269bf5
fix m_freelist offset
ipelupessy Mar 22, 2018
b6e23ef
cleanup
ipelupessy Mar 22, 2018
f2e2d6a
wip (uncleaned) fixes for bidirmmap to allow clean shutdown and restart
ipelupessy Mar 26, 2018
204ab16
Remove useless variable
egpbos Mar 26, 2018
2afe7ca
remove some superfluous output
ipelupessy Mar 26, 2018
b74217d
Merge branch 'MultiProcess_Vector' of https://github.com/roofit-dev/r…
egpbos Mar 26, 2018
5a0a40d
Merge branch 'MultiProcess_Vector' of https://github.com/roofit-dev/r…
egpbos Mar 26, 2018
32057d7
Small fix
egpbos Mar 26, 2018
745402e
Update copyright message
egpbos Mar 26, 2018
33471d7
Commented out more superfluous prints
egpbos Mar 26, 2018
bda12ae
Remove explicit terminate call
egpbos Mar 26, 2018
9b0608b
Comment cleanup, some doc rewrites and rename director -> master
egpbos Mar 26, 2018
352d54c
add test for BidirMMapPipe
ipelupessy Mar 26, 2018
2ba4dba
possible fix for shutdown exception, needs check
ipelupessy Mar 26, 2018
0584cc4
some more tests for bidirmmappipe
ipelupessy Mar 26, 2018
1acb2b0
WIP: Debugging BidirMMapPipe PagePool::release exceptions
egpbos Mar 27, 2018
8a05fdd
WIP: Debugging BidirMMapPipe PagePool::release exceptions
egpbos Mar 27, 2018
4d7de7e
fix pointer deref
ipelupessy Mar 27, 2018
5419f9a
Rename BidirMMapPipe tests
egpbos Mar 28, 2018
c77f79e
Added hierarchical forking tests (grandchildren) for BidirMMapPipe
egpbos Mar 28, 2018
886ac52
Added hierarchical polling test for BidirMMapPipe
egpbos Mar 28, 2018
d949abc
Added EXPECT_EQ to BidirMMapPipe hierarchical polling test
egpbos Mar 28, 2018
2ee9456
Remove some duplicate code from BidirMMapPipe test
egpbos Mar 28, 2018
7fc0887
Fixed EOF errors in pollHierarchy BidirMMapPipe test
egpbos Mar 28, 2018
4de5e58
Tidy up + put worker_loop in Job to make MultiJob test work (WIP)
egpbos Mar 29, 2018
98a8437
WIP: fix MultiJob test
egpbos Mar 29, 2018
a257920
Fixed MultiJob test (add check for running worker_loop)
egpbos Apr 4, 2018
2a1fe96
Clean up prints and comments
egpbos Apr 4, 2018
d7fc572
MultiJob tests added for multiple workers, which fails
egpbos Apr 4, 2018
0161849
Fixed MultiJob tests for multiple workers
egpbos Apr 4, 2018
31f1d9c
Clean up
egpbos Apr 5, 2018
438dfe3
NLL test fixed and extended; using Kahan sum
egpbos Apr 5, 2018
cc13fbe
Clean up
egpbos Apr 5, 2018
6741476
WIP: implementing updating of parameters
egpbos Apr 5, 2018
96c17a5
Fix getVal test (remove forceCalc)
egpbos Apr 17, 2018
a962d45
Clean-up + Implement work-/update-mode, fixes setVal tests
egpbos May 1, 2018
ea968d7
Properly implement dequeue handshake protocol
egpbos May 1, 2018
9fea52c
WIP: adding way to call methods on workers via function pointers
egpbos May 1, 2018
3e97b85
Implemented way to call methods on workers via function pointers
egpbos May 3, 2018
83b2feb
WIP: switch to Job-defined result specification: compiles, but hangs
egpbos May 3, 2018
c7509fe
Fixed segfault hang, but now hitting another segfault...
egpbos May 9, 2018
d2f73df
Fixed next segfault bug, running again, though still with test failures
egpbos May 9, 2018
ef54df7
Fixed test failures on dummy class tests
egpbos May 9, 2018
897d6ee
Fixed test failures on NLL tasks... except the ones with precision fails
egpbos May 9, 2018
5e777b2
Added MPFE multi-CPU cross-check tests + fixed them via RooTaskSpec
egpbos May 22, 2018
f1513f7
Comment out RooTaskSpec debug prints
egpbos May 22, 2018
2e39b59
Replace gRandom by RooRandom::randomGenerator()
egpbos May 22, 2018
3f1c091
Find seeds at which tests fail again + add nice hex output
egpbos May 22, 2018
16b1790
Add multiple seeds to NLL test to probe full range of failing tests
egpbos May 23, 2018
75561ea
Clean up + added diagnostic print
egpbos May 23, 2018
8a7bd08
Throw on creating MP-NLL with MPFE-NLL & EXPECT_DOUBLE_EQ for most tests
egpbos May 23, 2018
886746f
Added minimize integration test, fails on floating-point differences
egpbos May 23, 2018
f385cb5
Fixed minimize integration tests
egpbos May 24, 2018
6765b21
Move MultiProcess things into files + BidirMMapPipe to MultiProcess dir
egpbos May 24, 2018
ebfd942
Simplify roofitcore CMakeLists file
egpbos May 24, 2018
bc6f39d
WIP: refactor MultiProcess into separate files
egpbos May 24, 2018
5084cad
Refactored MultiProcess into separate files
egpbos May 30, 2018
bdeea8b
Refactored MultiProcess::NLLVar into separate files
egpbos May 30, 2018
3fc503f
Add missing include for shared_ptr
egpbos May 30, 2018
b07810b
Some more includes tidying
egpbos May 30, 2018
9fb9947
Add GradMinimizer MultiProcess test
egpbos Jun 1, 2018
5c3e2ea
Refactoring to merge RooMinimizer and RooGradMinimizer
egpbos Jun 1, 2018
f963fdf
Add MultiProcess::GradMinimizer
egpbos Jun 1, 2018
bbd9854
Document virtual methods to override in Job and Vector
egpbos Jun 2, 2018
fd93146
Remove init_vars from Vector (wasn't used)
egpbos Jun 4, 2018
6298222
Additional Vector documentation tweaks
egpbos Jun 4, 2018
2301b59
Replace gRandom with RooRandom::randomGenerator() in tests
egpbos Jul 5, 2018
98f59b3
Working on MultiProcess::GradMinimizer, must implement
egpbos Jul 17, 2018
40d5093
Fix compilation with stubs and add NumericalDerivator setup stub and …
egpbos Jul 17, 2018
51a0e8d
Fix RooGradientFunction/NumericalDerivatorMinuit2
egpbos Jul 30, 2018
8df40e6
Merge branch 'fix_testRooGradMinimizer_BranchingPDF' into MultiProces…
egpbos Jul 30, 2018
110d01c
Add MinimizerFcn ctor variadic arguments to RooMinimizer + compile fixes
egpbos Jul 31, 2018
9fa118e
Merge branch 'MultiProcess_Vector' of https://github.com/roofit-dev/r…
egpbos Jul 31, 2018
cd4c02d
Merge remote-tracking branch 'origin/MultiProcess_Vector_lostcommits'…
egpbos Jul 31, 2018
447049c
Fix RooGradMinimizer tests
egpbos Aug 2, 2018
e0e5a57
Update .travis.yml
egpbos Aug 2, 2018
0cdc365
fix for rt library on linux
ipelupessy Jan 16, 2018
00ece78
Fix CMake on macOS
egpbos Aug 2, 2018
63c0304
Try using a 35m timeout to cache building
egpbos Aug 2, 2018
529b6a0
Fix runtime_error include
egpbos Aug 2, 2018
9523a23
Remove _parameter_has_limits, wasn't used
egpbos Aug 6, 2018
8a8c9c3
Base NumericalDerivatorMinuit2 on partial derivatives instead of full…
egpbos Aug 6, 2018
504b389
Travis: fix git diff (must be in source dir)
egpbos Aug 6, 2018
b177338
Merge branches 'MultiProcess_Vector' and 'travis_trusty2018_update' o…
egpbos Aug 6, 2018
403268f
Add tests to Travis configuration
egpbos Aug 6, 2018
cc38d0a
Refactor common testing setup into utility header
egpbos Aug 8, 2018
563c59d
Implemented MultiProcess::GradMinimizer + big refactoring of dependen…
egpbos Aug 20, 2018
f45127d
Added test stubs for RooAddition nll types
egpbos Aug 22, 2018
f93acb0
Fix test output
egpbos Sep 5, 2018
b988dc6
Rewrite TaskManager so that adding Jobs after forking is possible
egpbos Sep 5, 2018
448c524
Replace get_worker_pipe and get_queue_pipe by send/receive functions
egpbos Sep 6, 2018
174ac6e
Add (failing) test: run migrad multiple times on an MP::GradMinimizer
egpbos Sep 6, 2018
e9265a1
WIP: making it possible to shutdown and restart the queue/workers
egpbos Sep 9, 2018
5d849a6
Add CPU pinning to TaskManager
egpbos Sep 9, 2018
6d4aa4c
Add CPU pinning to TaskManager
egpbos Sep 9, 2018
05f11bb
Fix TaskManager CPU pinning
egpbos Sep 9, 2018
ecd5908
Merge branch 'MultiProcess_Vector_ShutdownRestart' into MultiProcess_…
egpbos Sep 14, 2018
4c74bc4
Merge remote-tracking branch 'upstream/master' into MultiProcess_Vector
egpbos Oct 11, 2018
c52ada3
Fix RooFit CMakeLists after upstream merge
egpbos Oct 11, 2018
df4ae99
Added function value caching optimization in NumericalDerivatorMinuit2
egpbos Oct 18, 2018
8b38608
Add function/gradient/derivative call counters for debugging
egpbos Oct 18, 2018
add871a
Add timing to GradMinimizerFcn
egpbos Oct 22, 2018
63d816c
TaskManager cleanup
egpbos Oct 23, 2018
579ea53
TaskManager: fix for zombies + debugging BidirMMapPipe management/exit
egpbos Oct 24, 2018
dea605e
WIP: replacing BidirMMapPipe with ZeroMQ
egpbos Oct 24, 2018
cdd3cc0
Add ZeroMQ stuff from LHCb (gitlab.cern.ch/raaij/generate_and_sort)
egpbos Oct 25, 2018
4047793
ZMQ cleanup
egpbos Oct 25, 2018
1fad69e
Add zmq.hxx to MultiProcess
egpbos Oct 25, 2018
8655b5f
Fix missing virtual destructor warning for RooMinimizerGenericPtr
egpbos Oct 30, 2018
bed86f0
Make ZeroMQSvc non-virtual
egpbos Oct 30, 2018
02a90db
Added RooFitZMQ module
egpbos Nov 22, 2018
637d066
Replaced BidirMMapPipe with ZeroMQ: tests passing, zombies dead, no m…
egpbos Nov 22, 2018
672c593
Fix compile bug on Linux (waitpid include)
egpbos Dec 18, 2018
6b98b0c
Remove ifdef NDEBUGs for timing in MP::GradMinimizerFcn
egpbos Jan 16, 2019
fd1dd48
Add timing output to GradMinimizerFcn::evaluate_task
egpbos Jan 30, 2019
bd2783d
Add method to flush output streams on forked processes
egpbos Jan 30, 2019
830d57f
Flush debug output to avoid processes' output from mixing
egpbos Feb 11, 2019
645659a
Fix: reset dequeue_acknowledged when switching back to work mode
egpbos Mar 6, 2019
95d985a
Add absolute time outputs to measure delays between processes
egpbos Mar 6, 2019
a332256
Switch to RooFit output streams for benchmarking info
egpbos Mar 6, 2019
8686943
Time line searches as well
egpbos Mar 6, 2019
5ac35f8
add CPU timing to GradMinimizerFcn::evaluate_task
egpbos Mar 15, 2019
2732390
Time initialization of gradient
egpbos Mar 15, 2019
d979ab0
Sprinkle timestampers around RooMinimizer::migrad
egpbos Mar 15, 2019
f1aadde
Sprinkle timestampers around RooMinimizer::migrad
egpbos Mar 15, 2019
26abaaf
Merge branch 'MP_ZeroMQ' of github.com:NLeSC/root-roofit-dev into MP_…
Mar 15, 2019
ce6e281
Optimization: loop over LAvectors one by one
egpbos Mar 27, 2019
09bdeee
Merge branch 'MP_ZeroMQ' of github.com:NLeSC/root-roofit-dev into MP_…
Mar 27, 2019
4384ef3
Additional timestamps in Minuit
egpbos Mar 28, 2019
8d98bc3
Fix build with chrono include
egpbos Mar 28, 2019
7105cdd
Add timestamps to synchronize_parameter_settings
egpbos Mar 28, 2019
19826a6
Add timestamps to NumericalDerivatorMinuit2::setup_differentiate
egpbos Mar 28, 2019
a5eb4c8
Add worker_id to previous timestamps
egpbos Mar 28, 2019
f57ea0e
Prints for fVal after line search and in derivator
egpbos Mar 28, 2019
74350b1
Added none_have_been_calculated parameter
egpbos Apr 8, 2019
33b49a4
Catch RooFitZMQ exceptions + cleanup unused code
egpbos May 7, 2019
2c13b8b
Fix for zombies in ZMQ test + different port (5555 used too much)
egpbos May 8, 2019
3158964
Fixes NWorkersSeed test in testVectorGradMinimizer
egpbos May 8, 2019
d7e33b3
Debug, messaging and timing output
egpbos Jun 20, 2019
274fa8f
Possible fix in TaskManager that didn't fix it all
egpbos Jun 20, 2019
aad21e2
Remove work_mode; fixes VectorNLL test!
egpbos Jun 20, 2019
386e706
Debug prints removed or moved into RooFit output streams
egpbos Jun 21, 2019
d47d3d8
removed unused roofitZMQ functions
egpbos Sep 13, 2019
0dbdd19
WIP: implementing new multiprocess design
egpbos Sep 13, 2019
464c061
WIP: debugging test_Job + added test_connection
egpbos Jan 8, 2020
93129e4
Replace exclusive PAIR sockets with PUSH and PULL sockets
egpbos Jan 9, 2020
5ec0bb2
Fix test_Job class: no shared_ptr but raw pointer (not owner)
egpbos Jan 9, 2020
ce745de
terminate using SIGTERM instead of zmq message
egpbos Jan 9, 2020
f73a584
ZMQ: remove retries in send/recv and remove error msgs
egpbos Jan 9, 2020
20a326e
Added ZMQ::ppoll based on libzmq zmq_poll
egpbos Feb 10, 2020
bc33a19
MultiProcess::Job test finally fixed!
egpbos Feb 10, 2020
9fbd21b
remove prints (debug, timing) & try-catches around send/receive in Me…
egpbos Mar 2, 2020
38f0068
add test_ProcessManager
egpbos Mar 2, 2020
edad5fb
ProcessManager also exits after destruction on forks
egpbos Mar 2, 2020
715a3a2
add ProcessManager multi-birth test + simplify tests
egpbos Mar 2, 2020
ced6d39
add stubs for remaining likelihood (test statistic) classes
egpbos Mar 5, 2020
b970838
put TestStatistic stubs in roofitcore
egpbos Mar 18, 2020
0b47789
WIP (compiles): flattening (Grad)MinimizerFcn inheritance tree to bui…
egpbos Mar 24, 2020
9f281a2
WIP (compiles) MinuitFcnGrad: implement default ctor
egpbos Mar 25, 2020
b72a2e8
WIP (compiles) MinuitFcnGrad: implement copy ctor
egpbos Mar 25, 2020
e678330
WIP (compiles) MinuitFcnGrad: implement dtor, Clone, NDim, hasGxxx an…
egpbos Mar 25, 2020
4faf20f
WIP (compiles) MinuitFcnGrad: implement synchronize_parameter_setting…
egpbos Mar 26, 2020
f8cfaad
WIP (compiles) MinuitFcnGrad: implement final missing methods + some …
egpbos Mar 26, 2020
b037904
WIP (compiles) MinuitFcnGrad: fix compile warnings, including adding …
egpbos Mar 26, 2020
273da87
WIP (compiles) MinuitFcnGrad: merged in RooGradMinimizerFcn features
egpbos Mar 26, 2020
d82d1d9
WIP (compiles) MinuitFcnGrad: minor cleanups
egpbos Mar 26, 2020
266faba
WIP (compiles) MinuitFcnGrad: change ctor signature
egpbos Mar 27, 2020
ff1eebe
WIP (no compile) RooMinimizer detemplatization: added RooAbsMinimizer…
egpbos Apr 23, 2020
bf46d99
WIP (no compile) RooMinimizer detemplatization: subclassed RooGradMin…
egpbos Apr 24, 2020
8513778
WIP (no compile) RooMinimizer detemplatization: fixed some build errors
egpbos Apr 28, 2020
a579927
Remove RooMinimizer::setOffsetting
egpbos Apr 28, 2020
02607cf
finished RooMinimizer detemplatization and RooFit::TestStatistics com…
egpbos Jun 25, 2020
387a87c
compile fixes for previous commit (local junk remaining)
egpbos Aug 4, 2020
d7048cd
Implements likelihood calculation classes + various fixes
egpbos Aug 19, 2020
52d8bd8
Fix old tests by refactoring NumericalDerivatorMinuit2 + some warning…
egpbos Aug 19, 2020
6ce18ee
Fix more tests by many small cuts and LikelihoodSerial
egpbos Oct 26, 2020
99515f1
Fix more tests
egpbos Nov 25, 2020
21b5bc6
Small edits to RooRealL and test (not fixed yet)
egpbos Nov 26, 2020
8c532bf
Add failing tests for Binned, Constraint and Multi likelihoods
egpbos Nov 26, 2020
7e213af
Fix RooRealL.setVal test
egpbos Nov 30, 2020
011410e
Fix RooRealL.minimize test, all RooRealL tests passing
egpbos Dec 1, 2020
9e05ede
Made RooAbsL dtor virtual to prevent memory leaks
egpbos Dec 1, 2020
c98d2de
first draft of RooSimultaneousL + some refactoring
egpbos Dec 3, 2020
4ba36fc
fix RooSimultaneousL tests in testLikelihoodSerial
egpbos Dec 17, 2020
b27fe96
fix cmake config
egpbos Dec 18, 2020
1209d54
add constraint likelihood(Serial) tests + use binned in SimBinned test
egpbos Dec 18, 2020
30accc9
rename RooConstraintL to RooSubsidiaryL
egpbos Feb 2, 2021
1b5ad61
add docstring for RooSubsidiaryL with purpose and numerical properties
egpbos Feb 2, 2021
32a4352
First working version of RooSubsidiaryL
egpbos Feb 19, 2021
cb2d411
add likelihood_builders, replaces RooSimultaneousL ctor
egpbos Mar 2, 2021
3ff1ffb
add unbinned, constrained builder to likelihood_builders
egpbos Mar 2, 2021
a67e7ee
replace duplicate constraint creation with build_constraints
egpbos Mar 2, 2021
443e44e
revert changes to .travis.yml by Patrick Bos
egpbos Mar 9, 2021
761ea53
add delegating convenience overload
egpbos Mar 10, 2021
b0b6a2e
add LikelihoodSerial test
egpbos Mar 11, 2021
2f4a8d4
rename testLikelihoodGradientJob.cpp
egpbos Mar 11, 2021
6dc9923
ProcessManager fixes for Linux
Mar 12, 2021
e8ff070
Merge branch 'MP_ZeroMQ-new_multiprocess' of github.com:roofit-dev/ro…
Mar 12, 2021
1948bc4
add LikelihoodGradientJob tests
egpbos Mar 12, 2021
4dfb5a2
add failing Messenger test
egpbos Mar 12, 2021
2aa9ab2
fix Messenger test; made Messenger more self-contained
egpbos Mar 19, 2021
837fcc3
clean up unused functions and debug prints
egpbos Mar 19, 2021
a93af66
fix remaining TestStatistics tests
egpbos Apr 9, 2021
d96f81e
optimization: better ZeroMQ usage + constant term optimization
egpbos Apr 15, 2021
7d4faef
include fix
Apr 15, 2021
184be99
remove debugging/timing prints
egpbos Apr 15, 2021
89cf4fa
added ZMQ test for trying out load balancing with push-pull
egpbos Apr 16, 2021
d350461
check whether worker SUB sockets are connected to master
egpbos Apr 19, 2021
6012e8a
add a Messenger test which fails before previous commit (and passes now)
egpbos Apr 19, 2021
06d9c0a
Merge master into MP_ZeroMQ-new_multiprocess (using imerge)
egpbos May 25, 2021
74371e4
fix compilation issues after merge
egpbos May 28, 2021
8045017
Merge branch 'master' into RooFit_MultiProcess_PR
egpbos May 29, 2021
fe3aa94
fix compile warnings
egpbos May 29, 2021
45c422d
fix DeepCode bot issues
egpbos Jun 1, 2021
b504011
Adding missing include
vincecr0ft Jun 2, 2021
8d751fc
Merge remote-tracking branch 'origin/RooFit_MultiProcess_PR' into Roo…
vincecr0ft Jun 2, 2021
4096e70
Merge branch 'master' into RooFit_MultiProcess_PR
egpbos Jun 2, 2021
f42af53
include ZeroMQ as a builtin
egpbos Jun 4, 2021
d01d16c
manually revert travis.yml to master version
egpbos Jun 4, 2021
ac380a3
manually revert travis.yml to master version
egpbos Jun 4, 2021
7079894
manually revert travis.yml to master version
egpbos Jun 4, 2021
17b60b1
revert unnecessary math/minuit2 changes
egpbos Jun 23, 2021
1b9c58f
Merge remote-tracking branch 'origin/RooFit_MultiProcess_PR' into Roo…
egpbos Jun 23, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -291,7 +291,7 @@ if(cxxmodules)
# including <cassert> still manages to respect NDEBUG properly.
CHECK_CXX_SOURCE_COMPILES("#undef NDEBUG
#include <cassert>
#define NDEBUG
#define NEBUG
#include <cassert>
int main() { assert(this code is not compiled); }"
CXX_SUPPORTS_MODULES)
Expand Down
Loading