Update minimal CMake version in favour of advances features it offers by oshadura · Pull Request #8336 · root-project/root

oshadura · 2021-06-04T09:06:08Z

Fixes as well #8280

(Thanks a lot to @amadio for pointing out the most reasonable for ROOT build system)

Update: sadly we can't move directly to 3.16 because Debian 10 has only cmake 3.13 packaged https://pkgs.org/search/?q=cmake

phsft-bot · 2021-06-04T09:06:21Z

Starting build on ROOT-debian10-i386/cxx14, ROOT-performance-centos8-multicore/default, ROOT-ubuntu16/nortcxxmod, mac1014/python3, mac11.0/cxx17, windows10/cxx14
How to customize builds

phsft-bot · 2021-06-04T09:06:44Z

Build failed on ROOT-performance-centos8-multicore/default.
Running on olbdw-01.cern.ch:/data/sftnight/workspace/root-pullrequests-build
See console output.

Errors:

[2021-06-04T09:06:41.029Z] CMake Error at CMakeLists.txt:7 (cmake_minimum_required):
[2021-06-04T09:06:41.029Z] CMake Error at /data/sftnight/workspace/root-pullrequests-build/rootspi/jenkins/root-build.cmake:1113 (message):

phsft-bot · 2021-06-04T09:08:49Z

Build failed on ROOT-debian10-i386/cxx14.
Running on pcepsft10.dyndns.cern.ch:/build/workspace/root-pullrequests-build
See console output.

Errors:

[2021-06-04T09:08:47.946Z] CMake Error at CMakeLists.txt:7 (cmake_minimum_required):
[2021-06-04T09:08:47.946Z] CMake Error at /home/sftnight/build/workspace/root-pullrequests-build/rootspi/jenkins/root-build.cmake:1113 (message):

phsft-bot · 2021-06-04T09:21:02Z

Starting build on ROOT-debian10-i386/cxx14, ROOT-performance-centos8-multicore/default, ROOT-ubuntu16/nortcxxmod, mac1014/python3, mac11.0/cxx17, windows10/cxx14
How to customize builds

phsft-bot · 2021-06-04T09:21:20Z

Build failed on ROOT-performance-centos8-multicore/default.
Running on olbdw-01.cern.ch:/data/sftnight/workspace/root-pullrequests-build
See console output.

amadio · 2021-06-04T09:23:15Z

  cmake_minimum_required(VERSION 3.16 FATAL_ERROR)
 else()
-  cmake_minimum_required(VERSION 3.9 FATAL_ERROR)
+  cmake_minimum_required(VERSION 3.12 FATAL_ERROR)


Wasn't this supposed to be 3.16? Also, I supposed in the same PR one should search and remove hacks for older versions (like the Python setup), as that will not be necessary anymore.

@amadio sadly we can't move directly to 3.16 because Debian 10 has only cmake 3.13 packaged https://pkgs.org/search/?q=cmake

Ok, if you want to keep Debian 10 support, I guess 3.12 is the minimal version to be worth an update.

I updated to 3.13 which is a bit closer to 3.16

I'd find it reasonable to install CMake 3.16 on our Debian machines, and to expect packagers to have to do the same. After all it's not a runtime requirement.

Can people still build against ROOT with older CMake?

I believe yes, but we will need to remove hacks #8280 or even maybe more workarounds somewhere..

(I will test such combination with rootest.git)

phsft-bot · 2021-06-04T09:24:27Z

Starting build on ROOT-debian10-i386/cxx14, ROOT-performance-centos8-multicore/default, ROOT-ubuntu16/nortcxxmod, mac1014/python3, mac11.0/cxx17, windows10/cxx14
How to customize builds

phsft-bot · 2021-06-04T09:24:50Z

Build failed on ROOT-performance-centos8-multicore/default.
Running on olbdw-01.cern.ch:/data/sftnight/workspace/root-pullrequests-build
See console output.

oshadura · 2021-06-04T09:31:23Z

@amadio looks like it will be still impossible to remove Python hacks in https://github.com/root-project/root/blob/master/cmake/modules/SearchRootCoreDeps.cmake: CMake 3.14 is the minimum because in 3.12 and 3.13, despite find_package(PythonX) being present, the Numpy-related variables are not set

amadio · 2021-06-04T09:33:44Z

Yes, I was thinking about the move happening to 3.16. If it's only to 3.12 or 3.13, then the hacks need to stay. However, it's probably better to drop Debian 10 support and go to CMake 3.16. Debian 10 users can still have up to ROOT 6.24 if they don't want to install CMake by hand.

oshadura · 2021-06-04T09:38:18Z

About debian looks like users can get higher cmake version from stable-bpo and testing repos (?): https://tracker.debian.org/pkg/cmake
@Axel-Naumann what do you think?

phsft-bot · 2021-06-04T11:01:07Z

Starting build on ROOT-debian10-i386/cxx14, ROOT-performance-centos8-multicore/default, ROOT-ubuntu16/nortcxxmod, mac1014/python3, mac11.0/cxx17, windows10/cxx14
How to customize builds

phsft-bot · 2021-06-04T11:01:21Z

Build failed on ROOT-performance-centos8-multicore/default.
Running on olbdw-01.cern.ch:/data/sftnight/workspace/root-pullrequests-build
See console output.

phsft-bot · 2021-06-04T11:03:36Z

Build failed on ROOT-debian10-i386/cxx14.
Running on pcepsft11.dyndns.cern.ch:/home/sftnight/build/workspace/root-pullrequests-build
See console output.

Errors:

[2021-06-04T11:03:30.152Z] CMake Error at CMakeLists.txt:7 (cmake_minimum_required):
[2021-06-04T11:03:30.152Z] CMake Error at /home/sftnight/build/workspace/root-pullrequests-build/rootspi/jenkins/root-build.cmake:1113 (message):

phsft-bot · 2021-06-04T11:09:42Z

Build failed on mac1014/python3.
Running on macphsft17.dyndns.cern.ch:/build/jenkins/workspace/root-pullrequests-build
See console output.

Errors:

[2021-06-04T11:09:38.821Z] CMake Error at CMakeLists.txt:7 (cmake_minimum_required):
[2021-06-04T11:09:38.821Z] CMake Error at /build/jenkins/workspace/root-pullrequests-build/rootspi/jenkins/root-build.cmake:1113 (message):

phsft-bot · 2021-06-04T11:33:34Z

Build failed on ROOT-ubuntu16/nortcxxmod.
Running on sft-ubuntu-1604-1.cern.ch:/build/workspace/root-pullrequests-build
See console output.

Failing tests:

projectroot.runtutorials.test_import_pandas

phsft-bot · 2021-06-04T12:16:44Z

Build failed on mac11.0/cxx17.
Running on macphsft20.dyndns.cern.ch:/Users/sftnight/build/workspace/root-pullrequests-build
See console output.

Errors:

[2021-06-04T12:16:40.770Z] CMake Error at cmake/modules/SearchInstalledSoftware.cmake:1727 (message):
[2021-06-04T12:16:40.770Z] CMake Error at /Users/sftnight/build/workspace/root-pullrequests-build/rootspi/jenkins/root-build.cmake:1113 (message):

oshadura · 2021-06-29T07:45:06Z

@phsft-bot build!

phsft-bot · 2021-06-29T07:45:12Z

Starting build on ROOT-debian10-i386/cxx14, ROOT-performance-centos8-multicore/default, ROOT-ubuntu16/nortcxxmod, mac1014/python3, mac11.0/cxx17, windows10/cxx14
How to customize builds

phsft-bot · 2021-06-29T07:45:25Z

Build failed on ROOT-debian10-i386/cxx14.
Running on pcepsft11.dyndns.cern.ch:/home/sftnight/build/workspace/root-pullrequests-build
See console output.

Errors:

[2021-06-29T07:45:24.677Z] CMake Error at /home/sftnight/build/workspace/root-pullrequests-build/rootspi/jenkins/root-build.cmake:1043 (message):

phsft-bot · 2021-06-29T07:45:26Z

Build failed on ROOT-performance-centos8-multicore/default.
Running on olbdw-01.cern.ch:/data/sftnight/workspace/root-pullrequests-build
See console output.

Errors:

[2021-06-29T07:45:25.149Z] CMake Error at /data/sftnight/workspace/root-pullrequests-build/rootspi/jenkins/root-build.cmake:1043 (message):

bellenot · 2021-06-29T11:39:49Z

@oshadura then why was it not failing before?

oshadura · 2021-06-29T11:42:53Z

@bellenot Maybe my guess is wrong, checking other PR https://lcgapp-services.cern.ch/root-jenkins/job/root-pullrequests-build/121249/consoleFull I see that python3.8 is actually available on this node. Do you know if CMake was updated on this node as well?
(FYI I just checked on my MacOS 11 and PR works)

oshadura · 2021-06-29T11:44:02Z

@phsft-bot build just on mac11.0/cxx17

phsft-bot · 2021-06-29T11:44:08Z

Starting build on mac11.0/cxx17
How to customize builds

bellenot · 2021-06-29T11:46:51Z

Do you know if CMake was updated on this node as well?

No idea. @Axel-Naumann ?

phsft-bot · 2021-06-29T11:49:48Z

Build failed on mac11.0/cxx17.
Running on macphsft23.dyndns.cern.ch:/Users/sftnight/build/workspace/root-pullrequests-build
See console output.

Errors:

[2021-06-29T11:49:47.763Z] CMake Error at cmake/modules/SearchInstalledSoftware.cmake:1751 (message):
[2021-06-29T11:49:47.763Z] CMake Error at /Users/sftnight/build/workspace/root-pullrequests-build/rootspi/jenkins/root-build.cmake:1112 (message):

oshadura · 2021-06-29T11:52:58Z

Yes cmake is updated, I will check where is a problem:

sftnight@macphsft23 ~ % cmake --version
cmake version 3.18.1

…to stdout

…raries twice

…lable in this version

phsft-bot · 2021-06-29T12:13:13Z

Starting build on ROOT-debian10-i386/cxx14, ROOT-performance-centos8-multicore/default, ROOT-ubuntu16/nortcxxmod, mac1014/python3, mac11.0/cxx17, windows10/cxx14
How to customize builds

phsft-bot · 2021-06-29T12:20:57Z

Build failed on mac1014/python3.
Running on macphsft17.dyndns.cern.ch:/build/jenkins/workspace/root-pullrequests-build
See console output.

Errors:

[2021-06-29T12:20:56.834Z] CMake Error at CMakeLists.txt:7 (cmake_minimum_required):
[2021-06-29T12:20:57.092Z] CMake Error at /build/jenkins/workspace/root-pullrequests-build/rootspi/jenkins/root-build.cmake:1112 (message):

oshadura · 2021-06-29T12:23:16Z

@bellenot I think now PR is ready, before I made a small typo. The only problem is that all MacOS nodes need to have updated CMake (e.g. see macphsft17.dyndns.cern.ch)...

bellenot · 2021-06-29T12:24:45Z

Thanks a lot @oshadura ! I'll ask @Axel-Naumann if one can update CMake on all the MacOS nodes

phsft-bot · 2021-06-29T13:18:20Z

Build failed on ROOT-debian10-i386/cxx14.
Running on pcepsft10.dyndns.cern.ch:/build/workspace/root-pullrequests-build
See console output.

Failing tests:

bellenot · 2021-06-30T07:02:18Z

@phsft-bot build

phsft-bot · 2021-06-30T07:02:23Z

Starting build on ROOT-debian10-i386/cxx14, ROOT-performance-centos8-multicore/default, ROOT-ubuntu16/nortcxxmod, mac1014/python3, mac11.0/cxx17, windows10/cxx14
How to customize builds

phsft-bot · 2021-06-30T09:47:25Z

Build failed on ROOT-debian10-i386/cxx14.
Running on pcepsft10.dyndns.cern.ch:/build/workspace/root-pullrequests-build
See console output.

Failing tests:

And 5 more

bellenot · 2021-08-02T09:02:21Z

@phsft-bot build

phsft-bot · 2021-08-02T09:02:27Z

Starting build on ROOT-debian10-i386/cxx14, ROOT-performance-centos8-multicore/default, ROOT-ubuntu16/nortcxxmod, mac1014/python3, mac11.0/cxx17, windows10/cxx14
How to customize builds

phsft-bot · 2021-08-02T09:42:38Z

Build failed on ROOT-debian10-i386/cxx14.
Running on pcepsft10.dyndns.cern.ch:/build/workspace/root-pullrequests-build
See console output.

Errors:

[2021-08-02T09:04:40.998Z] stderr: error: could not read '.git/rebase-apply/head-name': No such file or directory

Failing tests:

projectroot.roottest.python.cpp.roottest_python_cpp_cpp

…root-project#8336) * Update minimal CMake version in favour of advances features it offers * Remove workaround for FindDoxygen (cmake < 3.13) * Remnove workaround for cmake < 3.14 to able to report issue directly to stdout * Remove workaround for CMake < 3.14 when Ninja 1.9.0 builds static libraries twice * Remove other CMake hack from multi-python ROOT builds * We are using 3.16 as a min CMake version and REGEX is definitely available in this version * Remove code used to search Python2/Python3 with <= CMake 3.14

oshadura requested review from Axel-Naumann, amadio and vgvassilev June 4, 2021 09:06

oshadura force-pushed the update-cmake-3.16 branch from 0b31f44 to f4bd71b Compare June 4, 2021 09:20

amadio reviewed Jun 4, 2021

View reviewed changes

oshadura force-pushed the update-cmake-3.16 branch from f4bd71b to 3c86e9f Compare June 4, 2021 09:24

oshadura force-pushed the update-cmake-3.16 branch from 3c86e9f to c74183c Compare June 4, 2021 11:00

oshadura mentioned this pull request Jun 4, 2021

Remove not needed fatal message (fixing #8280) #8341

Merged

oshadura self-assigned this Jun 7, 2021

oshadura requested a review from bellenot June 29, 2021 07:44

oshadura added 6 commits June 29, 2021 14:12

Remove workaround for FindDoxygen (cmake < 3.13)

d2caabf

Remnove workaround for cmake < 3.14 to able to report issue directly …

5c2fa7e

…to stdout

Remove workaround for CMake < 3.14 when Ninja 1.9.0 builds static lib…

dde2a1b

…raries twice

Remove other CMake hack from multi-python ROOT builds

2b4a98f

We are using 3.16 as a min CMake version and REGEX is definitely avai…

445c4fb

…lable in this version

Remove code used to search Python2/Python3 with <= CMake 3.14

186a2f0

oshadura force-pushed the update-cmake-3.16 branch from 85c7499 to 186a2f0 Compare June 29, 2021 12:13

oshadura requested review from bellenot and removed request for bellenot July 13, 2021 14:09

bellenot approved these changes Aug 4, 2021

View reviewed changes

bellenot merged commit f68ed04 into root-project:master Aug 4, 2021

Uh oh!

Conversation

oshadura commented Jun 4, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

phsft-bot commented Jun 4, 2021

Uh oh!

phsft-bot commented Jun 4, 2021

Errors:

Uh oh!

phsft-bot commented Jun 4, 2021

Errors:

Uh oh!

phsft-bot commented Jun 4, 2021

Uh oh!

phsft-bot commented Jun 4, 2021

Uh oh!

amadio Jun 4, 2021

Choose a reason for hiding this comment

Uh oh!

oshadura Jun 4, 2021

Choose a reason for hiding this comment

Uh oh!

amadio Jun 4, 2021

Choose a reason for hiding this comment

Uh oh!

oshadura Jun 4, 2021

Choose a reason for hiding this comment

Uh oh!

Axel-Naumann Jun 4, 2021

Choose a reason for hiding this comment

Uh oh!

oshadura Jun 4, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

oshadura Jun 4, 2021

Choose a reason for hiding this comment

Uh oh!

phsft-bot commented Jun 4, 2021

Uh oh!

phsft-bot commented Jun 4, 2021

Uh oh!

oshadura commented Jun 4, 2021

Uh oh!

amadio commented Jun 4, 2021

Uh oh!

oshadura commented Jun 4, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

phsft-bot commented Jun 4, 2021

Uh oh!

phsft-bot commented Jun 4, 2021

Uh oh!

phsft-bot commented Jun 4, 2021

Errors:

Uh oh!

phsft-bot commented Jun 4, 2021

Errors:

Uh oh!

phsft-bot commented Jun 4, 2021

Failing tests:

Uh oh!

phsft-bot commented Jun 4, 2021

Errors:

Uh oh!

oshadura commented Jun 29, 2021

Uh oh!

phsft-bot commented Jun 29, 2021

Uh oh!

phsft-bot commented Jun 29, 2021

Errors:

Uh oh!

phsft-bot commented Jun 29, 2021

Errors:

Uh oh!

bellenot commented Jun 29, 2021

Uh oh!

oshadura commented Jun 29, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

oshadura commented Jun 4, 2021 •

edited

Loading

oshadura Jun 4, 2021 •

edited

Loading

oshadura commented Jun 4, 2021 •

edited

Loading

oshadura commented Jun 29, 2021 •

edited

Loading

oshadura commented Jun 29, 2021 •

edited

Loading