Skip to content

[cling] Also fwd decl underlying type of using decls: [v6.24]#8516

Merged
Axel-Naumann merged 1 commit into
root-project:v6-24-00-patchesfrom
Axel-Naumann:issue8499-v624
Jun 23, 2021
Merged

[cling] Also fwd decl underlying type of using decls: [v6.24]#8516
Axel-Naumann merged 1 commit into
root-project:v6-24-00-patchesfrom
Axel-Naumann:issue8499-v624

Conversation

@Axel-Naumann

Copy link
Copy Markdown
Member

Before, only the using decl itself was forward declared, causing
undeclared identifiers in forward declaration code, as witnessed in
#8499

Given the similarity of using and typedef, merge both into a single
function, making sure both have the same featureset, and through that
fixing this issue as a side-effect.

(cherry picked from commit d026b49)

Before, only the using decl itself was forward declared, causing
undeclared identifiers in forward declaration code, as witnessed in
root-project#8499

Given the similarity of using and typedef, merge both into a single
function, making sure both have the same featureset, and through that
fixing this issue as a side-effect.

(cherry picked from commit d026b49)
@Axel-Naumann Axel-Naumann added this to the 6.24/02 milestone Jun 23, 2021
@Axel-Naumann Axel-Naumann self-assigned this Jun 23, 2021
@phsft-bot

Copy link
Copy Markdown

Starting build on ROOT-debian10-i386/cxx14, ROOT-performance-centos8-multicore/default, ROOT-ubuntu16/nortcxxmod, mac1014/python3, mac11.0/cxx17, windows10/cxx14
How to customize builds

@Axel-Naumann Axel-Naumann linked an issue Jun 23, 2021 that may be closed by this pull request
@Axel-Naumann

Copy link
Copy Markdown
Member Author

C8 failures are expected / unrelated.

@Axel-Naumann

Copy link
Copy Markdown
Member Author

Confirmed as fixing the underlying issue by Peter Hristov / ALICE. Thanks!

@Axel-Naumann Axel-Naumann merged commit 9a7ea6f into root-project:v6-24-00-patches Jun 23, 2021
@Axel-Naumann Axel-Naumann deleted the issue8499-v624 branch June 23, 2021 18:43
@Axel-Naumann Axel-Naumann changed the title [cling] Also fwd decl underlying type of using decls: [cling] Also fwd decl underlying type of using decls: [v6.24] Jun 24, 2021
@phsft-bot

Copy link
Copy Markdown

Starting build on ROOT-debian10-i386/cxx14, ROOT-performance-centos8-multicore/default, ROOT-ubuntu16/nortcxxmod, mac1014/python3, mac11.0/cxx17, windows10/cxx14
How to customize builds

@phsft-bot

Copy link
Copy Markdown

Build failed on ROOT-performance-centos8-multicore/default.
Running on olbdw-01.cern.ch:/data/sftnight/workspace/root-pullrequests-build
See console output.

Errors:

  • [2021-06-24T12:39:51.383Z] CMake Error at /data/sftnight/workspace/root-pullrequests-build/rootspi/jenkins/root-build.cmake:1043 (message):

@phsft-bot

Copy link
Copy Markdown

Build failed on ROOT-ubuntu16/nortcxxmod.
Running on sft-ubuntu-1604-2.cern.ch:/build/workspace/root-pullrequests-build
See console output.

Errors:

  • [2021-06-24T12:40:59.899Z] CMake Error at /mnt/build/workspace/root-pullrequests-build/rootspi/jenkins/root-build.cmake:1043 (message):

@phsft-bot

Copy link
Copy Markdown

Build failed on ROOT-debian10-i386/cxx14.
Running on pcepsft10.dyndns.cern.ch:/build/workspace/root-pullrequests-build
See console output.

Errors:

  • [2021-06-24T12:42:12.164Z] CMake Error at /home/sftnight/build/workspace/root-pullrequests-build/rootspi/jenkins/root-build.cmake:1043 (message):

@phsft-bot

Copy link
Copy Markdown

Build failed on mac1014/python3.
Running on macphsft17.dyndns.cern.ch:/build/jenkins/workspace/root-pullrequests-build
See console output.

Errors:

  • [2021-06-24T13:02:11.598Z] CMake Error at /build/jenkins/workspace/root-pullrequests-build/rootspi/jenkins/root-build.cmake:1043 (message):

@phsft-bot

Copy link
Copy Markdown

Build failed on mac11.0/cxx17.
Running on macphsft23.dyndns.cern.ch:/Users/sftnight/build/workspace/root-pullrequests-build
See console output.

Errors:

  • [2021-06-24T13:09:05.538Z] CMake Error at /Users/sftnight/build/workspace/root-pullrequests-build/rootspi/jenkins/root-build.cmake:1043 (message):

@phsft-bot

Copy link
Copy Markdown

Build failed on windows10/cxx14.
Running on null:C:\build\workspace\root-pullrequests-build
See console output.

Errors:

  • [2021-06-24T14:31:28.577Z] CMake Error at C:/build/workspace/root-pullrequests-build/rootspi/jenkins/root-build.cmake:1043 (message):

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Dict type alias fwd decl: underlying type not fwd declared

3 participants