Add Minuit2 On by default#8689
Merged
Merged
Conversation
|
Starting build on |
|
Build failed on ROOT-debian10-i386/cxx14. Errors:
Failing tests: |
bellenot
approved these changes
Jul 16, 2021
guitargeek
approved these changes
Jul 16, 2021
guitargeek
left a comment
guitargeek
left a comment
Contributor
There was a problem hiding this comment.
Thanks! Let's see if we can do something to avoid this Minuit2 dependency before the next release, for example by using the same plugin structure for the gradient-computing classes we have also for the minimizer (with RooMinimizer)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR sets Minuit2 building to ON by default in the make ROOT build option file.
This is needed now since Roofit now depends on Minuit2