[RF] Avoid using forward-declared class as default template arguments#8997
Merged
Merged
Conversation
guitargeek
force-pushed
the
patrick_pr_6_fixup_1
branch
2 times, most recently
from
1b3652e to
fc902bf
Compare
guitargeek
changed the title
RooSentinel::activate() calls in RooMinimizer/RooMinuit
guitargeek
changed the title
RooSentinel::activate() calls in RooMinimizer/RooMinuit
guitargeek
force-pushed
the
patrick_pr_6_fixup_1
branch
from
fc902bf to
7e46fb6
Compare
Avoid using forward-declared class as default template arguments in
`RooMinimizer` and `MinuitFcnGrad`.
This is the fix for the following test failures in the nightlies:
```
projectroot.roottest.python.cling.roottest_python_cling_class
projectroot.roottest.python.cling.roottest_python_cling_api
projectroot.roottest.root.meta.tclass.regression.roottest_root_meta_tclass_regression_execNormalizationInfPy
projectroot.roottest.python.cling.roottest_python_cling_cling
projectroot.roottest.root.meta.enumPayloadManipulation.roottest_root_meta_enumPayloadManipulation_checkEnumFwdDecl
```
For sure we know that these failures got introduced by
root-project#8700.
The failures that we see since [root-project#8700](root-project#8700), here are the comments where the bot reported them first:
First Ubuntu 16 fail:
[root-project#8700 (comment)](root-project#8700 (comment))
First Windows 10 fail:
[root-project#8700 (comment)](root-project#8700 (comment))
I narrowed down the origin of this regression to a small part of the
diff of the full PR. The bad guy is some change in one of these files:
* roofit/roofitcore/inc/RooMinimizer.h
* roofit/roofitcore/test/CMakeLists.txt
* roofit/roofitcore/test/TestStatistics/testLikelihoodSerial.cxx
What was fishy in `RooMinimizer.h` was the usage of a forward-declared
class as default template argument. The default template arguments are
commented out now, because these will only become relevant in later
developments by @egpbos.
guitargeek
force-pushed
the
patrick_pr_6_fixup_1
branch
from
7e46fb6 to
7d02c84
Compare
|
Starting build on |
guitargeek
changed the title
|
Build failed on mac11.0/cxx17. Failing tests: |
|
Build failed on windows10/cxx14. Errors:
|
|
Build failed on ROOT-debian10-i386/cxx14. Failing tests: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Avoid using forward-declared class as default template arguments in
RooMinimizerandMinuitFcnGrad.This is the fix for the following test failures in the nightlies:
For sure we know that these failures got introduced by
#8700.
The failures that we see since root-project#8700, here are the comments where the bot reported them first:
First Ubuntu 16 fail:
root-project#8700 (comment)
First Windows 10 fail:
root-project#8700 (comment)
I narrowed down the origin of this regression to a small part of the
diff of the full PR. The bad guy is some change in one of these files:
What was fishy in
RooMinimizer.hwas the usage of a forward-declaredclass as default template argument. The default template arguments are
commented out now, because these will only become relevant in later
developments by @egpbos.