Skip to content

Fix warning of unused variable in roofit#9368

Closed
ikabadzhov wants to merge 1 commit into
root-project:masterfrom
ikabadzhov:roofitRedundantVariables
Closed

Fix warning of unused variable in roofit#9368
ikabadzhov wants to merge 1 commit into
root-project:masterfrom
ikabadzhov:roofitRedundantVariables

Conversation

@ikabadzhov

Copy link
Copy Markdown
Contributor

This Pull request:

Casted variable rc to void in roofit/multiprocess/src/Messenger.cxx to disable the warning.
It is used only in assert statement besides the cast.

Changes or fixes: roofit/multiprocess/src/Messenger.cxx

Checklist:

  • tested changes locally
  • updated the docs (if necessary)

This PR fixes #

Casted variable rc to void in roofit/multiprocess/src/Messenger.cxx to disable the warning.
It is used only in assert statement besides the cast.
@phsft-bot

Copy link
Copy Markdown

Starting build on ROOT-debian10-i386/cxx14, ROOT-performance-centos8-multicore/default, ROOT-ubuntu16/nortcxxmod, ROOT-ubuntu2004/soversion, mac1015/python3, mac11/cxx17, windows10/cxx14
How to customize builds

@guitargeek

Copy link
Copy Markdown
Contributor

You can close this PR, we are already taking care of it: https://github.com/root-project/root/pull/9349/files#diff-03f30bc721fb7eb65916ce4552fb544751ad9dfde16e608227267692c0bc16a4

Whenever you see such warnings in an actively developed part of ROOT you can assume that somebody else will take care of it :)

@guitargeek guitargeek left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just and empty change request to block this PR from merging.

@guitargeek guitargeek removed their assignment Dec 3, 2021
@phsft-bot

Copy link
Copy Markdown

Build failed on ROOT-debian10-i386/cxx14.
Running on pcepsft10.dyndns.cern.ch:/build/workspace/root-pullrequests-build
See console output.

Errors:

  • [2021-12-03T16:24:31.518Z] stderr: error: Failed to merge in the changes.
  • [2021-12-03T16:24:36.686Z] CMake Error at /home/sftnight/build/workspace/root-pullrequests-build/rootspi/jenkins/root-build.cmake:1056 (message):

@guitargeek

Copy link
Copy Markdown
Contributor

This has already been fixed in #9349

@guitargeek guitargeek closed this Dec 6, 2021
@guitargeek guitargeek removed their assignment Dec 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants