Skip to content

[PyROOT] Compare floating point numbers from numba with isclose#994

Merged
hahnjo merged 1 commit into
root-project:masterfrom
hahnjo:numba-isclose
Aug 1, 2023
Merged

[PyROOT] Compare floating point numbers from numba with isclose#994
hahnjo merged 1 commit into
root-project:masterfrom
hahnjo:numba-isclose

Conversation

@hahnjo

@hahnjo hahnjo commented Jul 31, 2023

Copy link
Copy Markdown
Member

This will fix the test on macOS with LLVM 16 where interpreted code makes use of fma instructions that yield slightly different results.

This will fix the test on macOS with LLVM 16 where interpreted code
makes use of fma instructions that yield slightly different results.
@hahnjo hahnjo requested review from sudo-panda and vepadulano July 31, 2023 09:22
@hahnjo hahnjo self-assigned this Jul 31, 2023
@phsft-bot

Copy link
Copy Markdown

Starting build on ROOT-debian10-i386/soversion, ROOT-performance-centos8-multicore/cxx17, ROOT-ubuntu2204/nortcxxmod, ROOT-ubuntu2004/python3, mac11/noimt, mac12arm/cxx20, windows10/cxx14
How to customize builds

@root-project root-project deleted a comment from sonatype-lift Bot Jul 31, 2023

assert (False not in
tuple(x == y for x, y in numba_calc_pt_vec(vec_lv)))
tuple(math.isclose(x, y) for x, y in numba_calc_pt_vec(vec_lv)))

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

6% of developers fix this issue

E501: line too long (80 > 79 characters)


ℹ️ Expand to see all @sonatype-lift commands

You can reply with the following commands. For example, reply with @sonatype-lift ignoreall to leave out all findings.

Command Usage
@sonatype-lift ignore Leave out the above finding from this PR
@sonatype-lift ignoreall Leave out all the existing findings from this PR
@sonatype-lift exclude <file|issue|path|tool> Exclude specified file|issue|path|tool from Lift findings by updating your config.toml file

Note: When talking to LiftBot, you need to refresh the page to see its response.
Click here to add LiftBot to another repo.

@phsft-bot

Copy link
Copy Markdown

Build failed on ROOT-ubuntu2204/nortcxxmod.
Running on root-ubuntu-2204-3.cern.ch:/home/sftnight/build/workspace/roottest-pullrequests-build
See console output.

@sudo-panda sudo-panda left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@hahnjo hahnjo merged commit e5a16e4 into root-project:master Aug 1, 2023
@hahnjo hahnjo deleted the numba-isclose branch August 1, 2023 08:41
@phsft-bot

Copy link
Copy Markdown

Build failed on ROOT-debian10-i386/soversion.
Running on pcepsft11.dyndns.cern.ch:/home/sftnight/build/workspace/roottest-pullrequests-build
See console output.

Errors:

  • [2023-08-01T18:34:46.327Z] CMake Error at /home/sftnight/build/workspace/roottest-pullrequests-build/rootspi/jenkins/root-build.cmake:1144 (message):

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants