Merged
Conversation
Merge dev to staging
Merge dev to staging
Merge staging to production
Merge dev to staging
Merge staging to prod: affiliation matching improvements
Merge staging to dev: org status
Merge staging to master: org status
Merge dev to staging
Merge staging to master
Merge dev to staging: GRID removed IDs
Merge staging to prod: remove IDs from grid removed IDs var
Merge dev to staging
Merge stating to dev
Merge dev to staging: Remove auth header
Merge staging to master: Remove auth header
Merge staging to dev: Remove auth header from setup.py
Merge staging to master: remove auth header
Merge dev to staging: Filter bug fix
Merge staging to master: Filter bug fix
Remove curation ops files
Remove curation ops scripts
Merge dev to staging: sharding changes
Merge staging to master: sharding changes
Merge dev to staging: ES6 to ES7 upgrade
Merge dev to staging: Fix retrieve by ID
Merge staging to prod: ES6 to ES7 migration
Merge dev to staging: Generate ID hotfix
Merge staging to prod: Generate ID hotfix
Merge dev to staging: Add tests for all views and use API logic in generate ID
Contributor
|
@ashwinisukale can you please change the base branch to dev? |
| image: mysql:8.0 | ||
| volumes: | ||
| - mysql_data:/var/lib/mysql | ||
| environment: |
Contributor
There was a problem hiding this comment.
Please move these vars to .env file
Contributor
Author
|
Looks like |
lizkrznarich
requested changes
Mar 28, 2025
| def validate_email(self, value): | ||
| """Validate the email format and ensure it's unique.""" | ||
| if Client.objects.filter(email=value).exists(): | ||
| raise serializers.ValidationError("A client with this email already exists.") |
Contributor
There was a problem hiding this comment.
Again, per the spec, email does not need to be unique - users should be able to register multiple client IDs with the same email. Validation should check that email looks like a valid email (@ symbol and domain).
lizkrznarich
approved these changes
Apr 15, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.