Add configure() overload to set the initial LPF state - #657
Open
davmoli wants to merge 2 commits into
Open
Conversation
github-actions
Bot
requested review from
bmagyar,
erickisos,
homalozoa,
mhubii and
saikishor
August 13, 2026 19:52
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
LowPassFilteralways initializes its state from the firstupdate()input, so there'sno way to start it from a known value.
This PR adds a
configure(const T & initial_state)overload that seeds the state: the firstupdate()returnsinitial_stateand the filter converges towards the input from there.Fixes #643
Is this user-facing behavior change?
Yes, additive only. Existing
configure()calls behave exactly as before.Did you use Generative AI?
Implementation written by hand. Claude Code (Opus 5) reviewed it and helped write the unit tests.
Additional Information
The new tests cover all three supported types (
double,std::vector<double>,WrenchStamped). These are the first direct unit tests ofcontrol_toolbox::LowPassFilter;the existing ones only reach it through the plugin.
TODOs
To send us a pull request, please:
colcon testandpre-commit run(requires you to install pre-commit bypip3 install pre-commit)