[Parameters] Avoid deprecation warnings." - #616
Merged
Conversation
github-actions
Bot
requested review from
arne48,
bijoua29,
homalozoa,
jaron-l and
peterdavidfagan
May 16, 2023 07:01
destogl
enabled auto-merge (squash)
May 16, 2023 07:02
bmagyar
approved these changes
May 16, 2023
bmagyar
left a comment
bmagyar
left a comment
Member
There was a problem hiding this comment.
IMO this should be fine. Controllers are not really intended to be inherited, even though it happens from time to time.
gwalck
pushed a commit
to b-robotized-forks/ros2_controllers
that referenced
this pull request
Jun 7, 2023
* ci: 👷 Add ABI check to ros_indiustrial ci (ros-controls#597) * ci: 👷 Add ABI check to ros_indiustrial ci refs: ros-controls#583 * ci: 👷 change notation of ci * ci: 👷 change branch reference * ci: 👷 address PR comments * move abi check to spearate workflow * check abi against base ref * PR against galactic branch * No need to get angles from source anymore, causes issues now (backport ros-controls#616) (ros-controls#617) * No need to get angles from source anymore, causes issues now (ros-controls#616) (cherry picked from commit 2275f06) * fix spelling * Apply suggestions from code review Co-authored-by: Bence Magyar <bence.magyar.robotics@gmail.com> * first commit * namespace support for load_controller in controller_manager * cleaning up, renaming variables and other small fixes * renaming namespace to manager_namespace to avoid errors * removing namespaced param * add gitignore for __pycache__ folders * remove pycache ignore * run 'pre-commit run --all' and fix flake8 errors * switch init declaration (revert) * remove the need to modify hardware interface * remove useless function arguments * removing namespace argument from manager services * remove namespace from service messages * namespaced->prefixed + minor changes for readability * fix forgotten rebase conflicts * remove galactic related files * revert controller_manager constructor changes Co-authored-by: Jaron <13423952+jaron-l@users.noreply.github.com> Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com> Co-authored-by: Bence Magyar <bence.magyar.robotics@gmail.com> Co-authored-by: badr.moutalib <badr.moutalib@accenture.com> Co-authored-by: Hoang David HA <hoang.david.ha@accenture.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Maybe not suitable since ABI breaking…