Merged
Conversation
tfoote
approved these changes
Jan 8, 2018
Member
tfoote
left a comment
tfoote
left a comment
There was a problem hiding this comment.
I'm not completely familiar with it but it looks fine. Maybe a link to the documentation statement about the gcc version support would be helpful. In case it changes in the future.
Contributor
Author
|
@tfoote Struggling to find a good link, but I'll keep looking. This stackoverflow post confirms it, but I'd prefer a more formal source. |
zffgithub
pushed a commit
to zffgithub/superflore
that referenced
this pull request
Apr 11, 2023
* Turn off cuda for opencv3 if GCC > 4. This also simplifies the logic for special cases.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves ros/ros-overlay#280