Conversation
tfoote
approved these changes
Mar 20, 2018
zffgithub
pushed a commit
to zffgithub/superflore
that referenced
this pull request
Apr 11, 2023
* Add missing return statements * Fix import order and add get_pr_text test. * Add tests for clean_up function. * Add missing license tests. * Add test for resolve_dep with os='oe'.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This also includes an important fix for the PR text. Not sure when exactly it got pulled in, or how I didn't notice it, but it's a rather obvious bug fix.