Add --upstream-branch option#180
Merged
allenh1 merged 3 commits intoros-infrastructure:masterfrom Apr 28, 2019
Merged
Conversation
3 tasks
7958385 to
a7f4c3b
Compare
allenh1
reviewed
Apr 25, 2019
Contributor
allenh1
left a comment
There was a problem hiding this comment.
Overall this is looking pretty good. Left a note inline, but it is mostly a nit-pick.
Before this is merged, though, I'd really like to see some test cases introduced for the added option. If we want to, though, we can just create an issue for it after we merge this PR (since I'm not quite sure how in-depth those tests should go).
a7f4c3b to
459eaa3
Compare
allenh1
reviewed
Apr 26, 2019
Contributor
|
Coverage report for this branch: Still looking pretty good overall! @tfoote I don't think this affects it much, so I'm going to go ahead and approve this one. I'll leave it to you to merge it. |
allenh1
previously approved these changes
Apr 26, 2019
Contributor
allenh1
left a comment
There was a problem hiding this comment.
left some optional suggestions. lgtm
f5f1333 to
c20d72b
Compare
Merged
tfoote
approved these changes
Apr 27, 2019
zffgithub
pushed a commit
to zffgithub/superflore
that referenced
this pull request
Apr 11, 2023
* Add `--upstream-branch` option * Add parser tests for missing options * Update README.md with newer command line options
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.