Skip to content

Create GitHub Actions CI workflow based on travis job.#288

Merged
nuclearsandwich merged 3 commits intomasterfrom
add-github-actions-ci
Oct 29, 2021
Merged

Create GitHub Actions CI workflow based on travis job.#288
nuclearsandwich merged 3 commits intomasterfrom
add-github-actions-ci

Conversation

@nuclearsandwich
Copy link
Contributor

Also removes defunct travis.yml config.

Also removes defunct travis.yml config.
@nuclearsandwich nuclearsandwich self-assigned this Oct 28, 2021
@nuclearsandwich nuclearsandwich mentioned this pull request Oct 28, 2021
@nuclearsandwich
Copy link
Contributor Author

@allenh1 this PR adds GitHub Actions based CI for Superflore and may be useful in testing the 0.3.3 release.

Copy link
Contributor

@allenh1 allenh1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@nuclearsandwich thank you much! Looks good to me!

@allenh1
Copy link
Contributor

allenh1 commented Oct 29, 2021

@tfoote can you please remove the travis-ci requirement?

@nuclearsandwich
Copy link
Contributor Author

@tfoote can you please remove the travis-ci requirement?

I can do that.

@nuclearsandwich
Copy link
Contributor Author

can you please remove the travis-ci requirement?

I can do that.

Done. @allenh1 do you want to make any of the GitHub Actions checks required for merge?

@allenh1
Copy link
Contributor

allenh1 commented Oct 29, 2021

Done. @allenh1 do you want to make any of the GitHub Actions checks required for merge?

Yes please!

@nuclearsandwich nuclearsandwich merged commit cb6c424 into master Oct 29, 2021
@nuclearsandwich nuclearsandwich deleted the add-github-actions-ci branch October 29, 2021 21:05
@nuclearsandwich
Copy link
Contributor Author

Yes please!

I didn't make each individual check required but I did make several os/python-version combinations required and we can update those as platforms evolve.

zffgithub pushed a commit to zffgithub/superflore that referenced this pull request Apr 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants