Skip to content

Fix #35 - "bottom cannot be >= top" matplotlib error #52

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dirk-thomas merged 2 commits into from
Apr 3, 2020
Merged

Fix #35 - "bottom cannot be >= top" matplotlib error #52

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
06e14b0
Fix #35 - "bottom cannot be >= top" matplotlib error
bergercookie Apr 3, 2020
7dc31ef
renamed to `safe_tight_layout`, inverted logic to avoid duplicating t…
dirk-thomas Apr 3, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 17 additions & 2 deletions src/rqt_plot/data_plot/mat_data_plot.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -101,13 +101,28 @@ def __init__(self, parent=None):
super(MatDataPlot.Canvas, self).__init__(Figure())
self.axes = self.figure.add_subplot(111)
self.axes.grid(True, color='gray')
self.figure.tight_layout()
self.safe_tight_layout()
self.setSizePolicy(QSizePolicy.Expanding, QSizePolicy.Expanding)
self.updateGeometry()

def resizeEvent(self, event):
super(MatDataPlot.Canvas, self).resizeEvent(event)
self.figure.tight_layout()
self.safe_tight_layout()

def safe_tight_layout(self):
"""
Deal with "ValueError: bottom cannot be >= top" bug in older matplotlib versions
(before v2.2.3)

References:
- https://github.com/matplotlib/matplotlib/pull/10915
- https://github.com/ros-visualization/rqt_plot/issues/35
"""
try:
self.figure.tight_layout()
except ValueError:
if parse_version(matplotlib.__version__) >= parse_version('2.2.3'):
raise

limits_changed = Signal()

Expand Down