Fix Windows problem not finding ASIO.#116
Merged
jacobperron merged 2 commits intoros2-java:jacob/windows_workflowfrom Jun 29, 2020
Merged
Fix Windows problem not finding ASIO.#116jacobperron merged 2 commits intoros2-java:jacob/windows_workflowfrom
jacobperron merged 2 commits intoros2-java:jacob/windows_workflowfrom
Conversation
It basically needs an upgrade to setup-ros and action-ros-ci. Signed-off-by: Chris Lalancette <clalancette@openrobotics.org>
Contributor
Author
|
@jacobperron FYI. |
jacobperron
reviewed
Jun 29, 2020
Contributor
jacobperron
left a comment
jacobperron
left a comment
There was a problem hiding this comment.
Great, thanks for the patches upstream 👍
One small change
Signed-off-by: Chris Lalancette <clalancette@openrobotics.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It basically needs an upgrade to setup-ros and action-ros-ci.
Signed-off-by: Chris Lalancette clalancette@openrobotics.org
This still doesn't totally fix Windows, but gets us another step closer.