support rcl_action_count_clients and rcl_action_count_servers.#1294
Merged
support rcl_action_count_clients and rcl_action_count_servers.#1294
Conversation
Signed-off-by: Tomoya Fujita <Tomoya.Fujita@sony.com>
fujitatomoya
commented
Mar 12, 2026
Collaborator
Author
fujitatomoya
left a comment
fujitatomoya
left a comment
There was a problem hiding this comment.
@ahcorde this is base implementation to address ros2/ros2cli#1210, can you review this?
my next steps are,
- expose these functions to rclcpp and rclpy.
- ros2action uses rclpy new methods developed above.
- fix ros2action to print the consistent output format with ros2service and ros2topic.
ahcorde
requested changes
Mar 12, 2026
Signed-off-by: Tomoya Fujita <Tomoya.Fujita@sony.com>
Collaborator
Author
|
@ahcorde thanks for the review! all comments are addressed. |
Collaborator
Author
|
Pulls: #1294
|
ahcorde
approved these changes
Mar 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
part of ros2/ros2cli#1210
Fixes # (issue)
Is this user-facing behavior change?
No,
Did you use Generative AI?
Yes, Claude Sonnet 4.6
Additional Information