Skip to content

Cleanup rcl_logging_noop dependencies.#132

Merged
clalancette merged 1 commit intorollingfrom
clalancette/cleanup
Aug 4, 2025
Merged

Cleanup rcl_logging_noop dependencies.#132
clalancette merged 1 commit intorollingfrom
clalancette/cleanup

Conversation

@clalancette
Copy link
Contributor

@clalancette clalancette commented Jul 30, 2025

Description

It shouldn't build_export_depend anything (as nothing downstream should link against it), and all of its dependencies can be private.

Is this user-facing behavior change?

No.

Did you use Generative AI?

No.

Additional Information

N/A

@clalancette
Cleanup rcl_logging_noop dependencies.
d3075a0 
It shouldn't build_export_depend anything (as nothing
downstream should link against it), and all of its
dependencies can be private.

Signed-off-by: Chris Lalancette <clalancette@gmail.com>
fujitatomoya
fujitatomoya approved these changes Jul 30, 2025
View reviewed changes
Copy link
Collaborator

@fujitatomoya fujitatomoya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm with green CI.

@fujitatomoya
Copy link
Collaborator

fujitatomoya commented Jul 30, 2025

Pulls: #132
Gist: https://gist.githubusercontent.com/fujitatomoya/44b4c48bde95cb2354fa24a445be2e7e/raw/1c0aa1d36b8adf0992a186fe1b888e3145fc87fc/ros2.repos
BUILD args: --packages-above-and-dependencies rcl_logging_noop
TEST args: --packages-above rcl_logging_noop
ROS Distro: rolling
Job: ci_launcher
ci_launcher ran: https://ci.ros2.org/job/ci_launcher/16656

  • Linux Build Status
  • Linux-aarch64 Build Status
  • Linux-rhel Build Status
  • Windows Build Status

@clalancette
Copy link
Contributor Author

clalancette commented Aug 4, 2025

Pulls: #132
Gist: https://gist.githubusercontent.com/clalancette/9287a26ff74cc115efcc2429fff7bfa0/raw/1c0aa1d36b8adf0992a186fe1b888e3145fc87fc/ros2.repos
BUILD args: --packages-above-and-dependencies rcl_logging_noop
TEST args: --packages-above rcl_logging_noop
ROS Distro: rolling
Job: ci_launcher
ci_launcher ran: https://ci.ros2.org/job/ci_launcher/16663

  • Linux Build Status
  • Linux-aarch64 Build Status
  • Linux-rhel Build Status
  • Windows Build Status

@clalancette clalancette merged commit 06814b3 into rolling Aug 4, 2025
3 checks passed
@clalancette clalancette deleted the clalancette/cleanup branch August 4, 2025 15:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@fujitatomoya fujitatomoya fujitatomoya approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@clalancette @fujitatomoya