Skip to content

Cleanup the rclpy dependencies.#1482

Merged
clalancette merged 1 commit intorollingfrom
clalancette/cleanup
Aug 4, 2025
Merged

Cleanup the rclpy dependencies.#1482
clalancette merged 1 commit intorollingfrom
clalancette/cleanup

Conversation

@clalancette
Copy link
Contributor

@clalancette clalancette commented Jul 29, 2025

Description

Most importantly, we switch all dependencies to split out <build_depend>/<exec_depend>, rather than using . That's because implies <build_export_depend>, but we never want downstream libraries to link against nor try to #include the library that we build here.

Is this user-facing behavior change?

No.

Did you use Generative AI?

No

Additional Information

N/A

@clalancette
Cleanup the rclpy dependencies.
b8a1082 
Most importantly, we switch all dependencies to split
out <build_depend>/<exec_depend>, rather than using <depend>.
That's because <depend> implies <build_export_depend>, but
we never want downstream libraries to link against nor try
to #include the library that we build here.

Signed-off-by: Chris Lalancette <clalancette@gmail.com>
@ahcorde
Copy link
Contributor

ahcorde commented Jul 30, 2025 •
edited by clalancette
Loading

Pulls: #1482
Gist: https://gist.githubusercontent.com/ahcorde/631e8ab03d4e83a4fb8a7ff6f2f594c8/raw/c086803879c0bf036aa71107a51f55b6a9dbc2da/ros2.repos
BUILD args: --packages-above-and-dependencies rclpy
TEST args: --packages-above rclpy
ROS Distro: rolling
Job: ci_launcher
ci_launcher ran: https://ci.ros2.org/job/ci_launcher/16649

  • Linux Build Status
  • Linux-aarch64 Build Status
  • Linux-rhel Build Status
  • Windows Build Status

fujitatomoya
fujitatomoya approved these changes Jul 31, 2025
View reviewed changes
Copy link
Collaborator

@fujitatomoya fujitatomoya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm with green CI.

@clalancette
Copy link
Contributor Author

clalancette commented Aug 4, 2025

Pulls: #1482
Gist: https://gist.githubusercontent.com/clalancette/02a49c8c043a238bd902cf62e2fea832/raw/c086803879c0bf036aa71107a51f55b6a9dbc2da/ros2.repos
BUILD args: --packages-above-and-dependencies rclpy
TEST args: --packages-above rclpy
ROS Distro: rolling
Job: ci_launcher
ci_launcher ran: https://ci.ros2.org/job/ci_launcher/16662

  • Linux Build Status
  • Linux-aarch64 Build Status
  • Linux-rhel Build Status
  • Windows Build Status

@clalancette clalancette merged commit f3a326c into rolling Aug 4, 2025
3 checks passed
@clalancette clalancette deleted the clalancette/cleanup branch August 4, 2025 15:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ahcorde ahcorde ahcorde approved these changes

@fujitatomoya fujitatomoya fujitatomoya approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@clalancette @ahcorde @fujitatomoya