Use <lttng/lttng.h> in lttngpy and clean up includes#222
Use <lttng/lttng.h> in lttngpy and clean up includes#222christophebedard merged 4 commits intoros2:rollingfrom
Conversation
…sage Signed-off-by: Reece Holland <reece.j.holland@gmail.com>
Signed-off-by: Reece Holland <reece.j.holland@gmail.com>
46137e8 to
3153b69
Compare
christophebedard
left a comment
There was a problem hiding this comment.
Thanks for the PR! I just have some minor comments.
Signed-off-by: Reece Holland <reece.j.holland@gmail.com>
|
Updated per review: added <lttng/lttng.h> to all lttng-ctl users, fixed include ordering, and kept the formatting commit separate. Thanks! |
Signed-off-by: Reece Holland <reece.j.holland@gmail.com>
christophebedard
left a comment
There was a problem hiding this comment.
Looks good, thank you again for the PR and thank you for iterating with me! I'll trigger CI.
|
Pulls: #222 |
|
@Mergifyio backport kilted jazzy |
✅ Backports have been createdDetails
Cherry-pick of 91ff616 has failed: To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally
Cherry-pick of 91ff616 has failed: To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally |
Signed-off-by: Reece Holland <reece.j.holland@gmail.com> (cherry picked from commit 91ff616) # Conflicts: # lttngpy/src/lttngpy/snapshot.cpp
Signed-off-by: Reece Holland <reece.j.holland@gmail.com> (cherry picked from commit 91ff616) # Conflicts: # lttngpy/src/lttngpy/snapshot.cpp
Signed-off-by: Reece Holland <reece.j.holland@gmail.com>
Description
This PR updates lttngpy to use the recommended umbrella LTTng header:
instead of including individual LTTng headers (domain.h, event.h, lttng-error.h, etc.).
Changes:
No functional behavior changes are intended; this is an include/style cleanup.
Fixes #220
Is this user-facing behavior change?
Did you use Generative AI?
Additional Information