Skip to content

Skip CLI tests on Windows until we resolve the blocking/hanging isuse.#489

Merged
nuclearsandwich merged 1 commit intomasterfrom
nuclearsandwich/skip-cli-tests-on-win
Apr 16, 2020
Merged

Skip CLI tests on Windows until we resolve the blocking/hanging isuse.#489
nuclearsandwich merged 1 commit intomasterfrom
nuclearsandwich/skip-cli-tests-on-win

Conversation

@nuclearsandwich
Copy link
Copy Markdown
Member

@nuclearsandwich nuclearsandwich commented Apr 15, 2020

We've been lacking on Windows test data for months due to the blocking
or hung state that these tests can get into. I think the best thing to
do is skip these tests on windows to allow other builds to complete
while we continue investigating the problem.

I've opted for skipping entire test modules as I think the underlying issue is in the test apparatus rather than any specific test.

@nuclearsandwich
Skip CLI tests on Windows until we resolve the blocking/hanging isuse.
38c855f 
We've been lacking on Windows test data for months due to the blocking
or hung state that these tests can get into. I think the best thing to
do is skip these tests on windows to allow other builds to complete
while we continue investigating the problem.

Signed-off-by: Steven! Ragnarök <steven@nuclearsandwich.com>
@nuclearsandwich nuclearsandwich self-assigned this Apr 15, 2020
@nuclearsandwich
Copy link
Copy Markdown
Member Author

nuclearsandwich commented Apr 15, 2020

CI up to these packages and testing them. On Windows I want to check that the CLI tests are skipped and on other platforms I want to verify that they run as expected.

  • Linux Build Status
  • Linux-aarch64 Build Status
  • macOS Build Status
  • Windows Build Status

@nuclearsandwich nuclearsandwich mentioned this pull request Apr 15, 2020
Closed
jacobperron
jacobperron approved these changes Apr 15, 2020
View reviewed changes
Copy link
Copy Markdown
Member

@jacobperron jacobperron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SGTM

When we do our manually testing for Foxy, we can make sure to pick up the slack.

@nuclearsandwich
Copy link
Copy Markdown
Member Author

nuclearsandwich commented Apr 16, 2020

I'm pretty sure the test failures above were introduced by ros2/rclpy#536 (discussion). I am going to merge in order to improve the situation on Windows.

@nuclearsandwich nuclearsandwich merged commit 8ad1208 into master Apr 16, 2020
@nuclearsandwich nuclearsandwich deleted the nuclearsandwich/skip-cli-tests-on-win branch April 16, 2020 02:35
@dirk-thomas
Copy link
Copy Markdown
Member

dirk-thomas commented Apr 16, 2020

Please ticket the follow up task to revert this change.

@nuclearsandwich
Copy link
Copy Markdown
Member Author

nuclearsandwich commented Apr 16, 2020

Please ticket the follow up task to revert this change.

Do you feel an issue separate from ros2/build_farmer#248 is warranted?

@dirk-thomas
Copy link
Copy Markdown
Member

dirk-thomas commented Apr 16, 2020

I would be concerned that the task of reverting this change gets lost in the length and broader scope of that ticket.

@nuclearsandwich nuclearsandwich mentioned this pull request Apr 16, 2020
Open
@nuclearsandwich
Copy link
Copy Markdown
Member Author

nuclearsandwich commented Apr 16, 2020

I would be concerned that the task of reverting this change gets lost in the length and broader scope of that ticket.

#490

jacobperron added a commit that referenced this pull request Apr 16, 2020
@jacobperron
Skip tests on Windows
998e845 
Other CLI tests are skipped on Windows since #489.

To be reverted when ros2/build_farmer#248 is resolved.

Signed-off-by: Jacob Perron <jacob@openrobotics.org>
jacobperron added a commit that referenced this pull request Apr 16, 2020
@jacobperron
Skip tests on Windows
912b1ba 
Other CLI tests are skipped on Windows since #489.

To be reverted when ros2/build_farmer#248 is resolved.

Signed-off-by: Jacob Perron <jacob@openrobotics.org>
@ivanpauno ivanpauno mentioned this pull request Apr 17, 2020
Closed
jacobperron added a commit that referenced this pull request Apr 18, 2020
@jacobperron
[ros2param] Convert test_verb_dump into launch test (#485)
75e0ea1 
Fixes #480

The actual tests are the same, except with the use of launch_testing we ensure the CLI daemon
is restarted between tests. This follows a similar pattern as the other ros2cli tests.

In addition to converting to launch tests, this change also runs the tests for all RMW implementations.

For now, we are skipping tests on Windows. Other CLI tests are skipped on Windows since #489. To be reverted when ros2/build_farmer#248 is resolved.

Signed-off-by: Jacob Perron <jacob@openrobotics.org>
hidmic added a commit that referenced this pull request Jan 12, 2021
@hidmic
Revert "Skip CLI tests on Windows until we resolve the blocking/hangi…
a12d6e6 
…ng isuse. (#489)"

This reverts commit 8ad1208.
hidmic added a commit that referenced this pull request Jan 13, 2021
@hidmic
Revert "Skip CLI tests on Windows until we resolve the blocking/hangi…
4400ca6 
…ng isuse. (#489)"

This reverts commit 8ad1208.

Signed-off-by: Michel Hidalgo <michel@ekumenlabs.com>
hidmic added a commit that referenced this pull request Feb 18, 2021
@hidmic
Revert "Skip CLI tests on Windows until we resolve the blocking/hangi…
47b08b4 
…ng isuse. (#489)"

This reverts commit 8ad1208.

Signed-off-by: Michel Hidalgo <michel@ekumenlabs.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jacobperron jacobperron jacobperron approved these changes

Assignees

@nuclearsandwich nuclearsandwich

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@nuclearsandwich @dirk-thomas @jacobperron