fix: CI go-version from go.mod, gate client-registration injection, improve isAlreadyInjected#122
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR makes three focused improvements to the Kagenti webhook: automating Go version management in CI, fixing client-registration sidecar injection to respect the EnableClientRegistration flag, and improving the isAlreadyInjected detection to check for core containers that are always injected.
Changes:
- CI workflow now reads Go version from go.mod instead of hardcoding it
- Client-registration sidecar injection is now properly gated by the --enable-client-registration flag
- isAlreadyInjected now checks for envoy-proxy (sidecar) and proxy-init (init container) in addition to spiffe-helper and client-registration
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| .github/workflows/ci.yaml | Updates CI to read Go version from go.mod using go-version-file parameter |
| kagenti-webhook/internal/webhook/v1alpha1/authbridge_webhook.go | Enhances isAlreadyInjected to detect envoy-proxy and proxy-init containers |
| kagenti-webhook/internal/webhook/injector/pod_mutator.go | Gates client-registration sidecar injection behind EnableClientRegistration flag with appropriate logging |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
mrsabath
force-pushed
the
ci-and-webhook-fixes
branch
from
February 18, 2026 19:54
c4aa767 to
0dee81e
Compare
18 tasks
…mprove isAlreadyInjected - Use go-version-file instead of hardcoded go-version in CI workflow - Gate client-registration sidecar injection behind EnableClientRegistration flag - Add envoy-proxy and proxy-init container checks to isAlreadyInjected Signed-off-by: Mariusz Sabath <mrsabath@gmail.com>
mrsabath
force-pushed
the
ci-and-webhook-fixes
branch
from
February 18, 2026 20:32
0dee81e to
1bbc1f1
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Split out from PR #113 to keep that PR focused on CLAUDE.md files only.
Test plan