Skip to content

CI: Add PR title verifier workflow - #355

Merged
rubambiza merged 6 commits into
rossoctl:mainfrom
rubambiza:ci/add-pr-verifier
May 7, 2026
Merged

CI: Add PR title verifier workflow#355
rubambiza merged 6 commits into
rossoctl:mainfrom
rubambiza:ci/add-pr-verifier

Conversation

@rubambiza

Copy link
Copy Markdown
Contributor

Summary

  • Adds a caller workflow that invokes the org-level reusable PR title verifier from kagenti/.github
  • Enforces PR title prefix conventions (Feat, Fix, Docs, etc.) on all pull requests
  • No changes to existing workflows or repo configuration

Assisted-By: Claude Opus 4.6 <noreply@anthropic.com>

Signed-off-by: Gloire Rubambiza <gloire@ibm.com>
Assisted-By: Claude Opus 4.6 <noreply@anthropic.com>

Signed-off-by: Gloire Rubambiza <gloire@ibm.com>
Assisted-By: Claude Opus 4.6 <noreply@anthropic.com>

Signed-off-by: Gloire Rubambiza <gloire@ibm.com>
@rubambiza

Copy link
Copy Markdown
Contributor Author

Update: The reusable workflow in kagenti/.github is now live (PR #66 merged), so this caller workflow will fire correctly as soon as this PR is merged.

However, the pinned SHA in this workflow will need a final bump once kagenti/.github#67 merges. That PR adds FORCE_JAVASCRIPT_ACTIONS_TO_NODE24=true to suppress a Node.js 20 deprecation warning from the action-pr-title action (GitHub is removing Node 20 runner support on September 16, 2026). The action itself is safe for Node 24 (only uses @actions/core and @actions/github).

Once #67 merges, I'll push an updated SHA pin to this branch.

Assisted-By: Claude Opus 4.6 <noreply@anthropic.com>

Signed-off-by: Gloire Rubambiza <gloire@ibm.com>
Assisted-By: Claude Opus 4.6 <noreply@anthropic.com>

Signed-off-by: Gloire Rubambiza <gloire@ibm.com>
Assisted-By: Claude Opus 4.6 <noreply@anthropic.com>

Signed-off-by: Gloire Rubambiza <gloire@ibm.com>

@mrsabath mrsabath left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Clean caller workflow for the org-level PR title verifier. Verified the pinned SHA (4e535f2) exists in kagenti/.github — points to the April 29 merge of PR #67 (ci/force-node24). Good security posture with permissions: {} and proper PR event triggers.

Areas reviewed: CI/GitHub Actions, YAML, security (SHA pinning), commit conventions
Commits: 6 commits, all signed-off ✓
CI: All checks passing ✓


jobs:
verify-pr-title:
uses: kagenti/.github/.github/workflows/pr-verifier-required.yml@4e535f2436d167295d39d488ce5c44b5a2d49792

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

praise: Good security practices — permissions: {} at the top level (lets the reusable workflow declare its own minimal permissions), and the reusable workflow reference is pinned to a full SHA rather than a branch or tag. Verified: 4e535f2 → merge of rossoctl/.github#67 (April 29).

@rubambiza
rubambiza merged commit bd68879 into rossoctl:main May 7, 2026
17 checks passed
@rubambiza
rubambiza deleted the ci/add-pr-verifier branch May 7, 2026 19:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

2 participants