Skip to content

import tokenbroker #460

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
huang195 merged 1 commit into from
Jun 1, 2026
Merged

import tokenbroker #460

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions authbridge/cmd/authbridge-envoy/main.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,6 +52,7 @@ import (
_ "github.com/kagenti/kagenti-extensions/authbridge/authlib/plugins/inferenceparser"
_ "github.com/kagenti/kagenti-extensions/authbridge/authlib/plugins/jwtvalidation"
_ "github.com/kagenti/kagenti-extensions/authbridge/authlib/plugins/mcpparser"
_ "github.com/kagenti/kagenti-extensions/authbridge/authlib/plugins/tokenbroker"
_ "github.com/kagenti/kagenti-extensions/authbridge/authlib/plugins/tokenexchange"
)

Expand Down
1 change: 1 addition & 0 deletions authbridge/cmd/authbridge-lite/main.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,6 +40,7 @@ import (

// Only two plugins: drop the parsers and token-broker.

@huang195 huang195 Jun 1, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This comment now directly contradicts the code — it says token-broker is dropped, but this PR adds it. CodeRabbit flagged the same. Suggest updating to reflect the actual plugin set, e.g.:

// Three plugins: jwtvalidation, tokenbroker, tokenexchange (parsers dropped).

_ "github.com/kagenti/kagenti-extensions/authbridge/authlib/plugins/jwtvalidation"
_ "github.com/kagenti/kagenti-extensions/authbridge/authlib/plugins/tokenbroker"
_ "github.com/kagenti/kagenti-extensions/authbridge/authlib/plugins/tokenexchange"
Comment on lines 41 to 44

@coderabbitai coderabbitai Bot Jun 1, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🟡 Minor | ⚡ Quick win

Comment now contradicts the code: token-broker is no longer dropped.

Line 41 still says "drop the parsers and token-broker," but Line 43 compiles tokenbroker in. This is misleading for anyone auditing the lite binary's surface. Update both this comment and the package doc (Lines 1-3, "jwt-validation + token-exchange as the only plugins compiled in").

📝 Suggested fix 
-	// Only two plugins: drop the parsers and token-broker.
+	// Drop the parsers; keep the auth/token plugins.
 	_ "github.com/kagenti/kagenti-extensions/authbridge/authlib/plugins/jwtvalidation"
 	_ "github.com/kagenti/kagenti-extensions/authbridge/authlib/plugins/tokenbroker"
 	_ "github.com/kagenti/kagenti-extensions/authbridge/authlib/plugins/tokenexchange"

And the package header:

-// Package main is the "lite" authbridge binary: proxy-sidecar mode
-// only (no Envoy), with jwt-validation + token-exchange as the only
-// plugins compiled in. Optimizes for binary size by dropping the
+// Package main is the "lite" authbridge binary: proxy-sidecar mode
+// only (no Envoy), with jwt-validation, token-exchange, and
+// token-broker as the only plugins compiled in. Optimizes for binary
+// size by dropping the
🤖 Prompt for AI Agents 
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@authbridge/cmd/authbridge-lite/main.go` around lines 41 - 44, The inline
comment claiming "Only two plugins: drop the parsers and token-broker." is stale
because main.go imports jwtvalidation, tokenbroker and tokenexchange; update
that comment and the package header (lines 1-3) to accurately list the compiled
plugins (e.g., "jwtvalidation, tokenbroker, tokenexchange" or the intended
subset) so the package doc and the comment above the blank imports reflect the
actual set; search for the blank-imports _
"github.com/kagenti/.../plugins/jwtvalidation", _
"github.com/kagenti/.../plugins/tokenbroker", and _
"github.com/kagenti/.../plugins/tokenexchange" to place the corrected wording.

)

Expand Down
1 change: 1 addition & 0 deletions authbridge/cmd/authbridge-proxy/main.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,6 +45,7 @@ import (
_ "github.com/kagenti/kagenti-extensions/authbridge/authlib/plugins/inferenceparser"
_ "github.com/kagenti/kagenti-extensions/authbridge/authlib/plugins/jwtvalidation"
_ "github.com/kagenti/kagenti-extensions/authbridge/authlib/plugins/mcpparser"
_ "github.com/kagenti/kagenti-extensions/authbridge/authlib/plugins/tokenbroker"
_ "github.com/kagenti/kagenti-extensions/authbridge/authlib/plugins/tokenexchange"
)

Expand Down
Loading